feat(client): close the 8 reports-family REST gaps (#3587 batch 2/5) - #3626
Merged
Conversation
New client.reports namespace speaking the plugin-reports REST surface:
list / save / get / delete (schedules cascade), run, schedule,
listSchedules, unschedule — each URL-pinned in client.test.ts. The two
DELETE routes return 204; the client methods return { deleted: true }
without parsing the empty body. Fixed path (/api/v1/reports is not in
ApiRoutesSchema), matching the keys / share-links precedent.
Ledger: 8 reports rows gap→sdk; ratchet 34→26. client-sdk.mdx surface
table gains the reports row.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 18 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 27, 2026 11:10
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of five batches closing the 43 REST↔client gaps the #3587 ledger carries. Batch 1 (metadata 9, #3625) is merged; this batch: the reports family, 8 gaps → 0. Ratchet 34 → 26.
New
client.reportsnamespaceSpeaks the
plugin-reportsREST surface exactly asrest-server.ts#registerReportsEndpointsmounts it; every route 501s[NOT_IMPLEMENTED]on deployments without the reports service. Fixed path —/api/v1/reportsis not inApiRoutesSchema, same precedent askeys/shareLinks(#3575).list({object?, ownerId?})GET /reports{data}envelopesave(report)POST /reports[VALIDATION_FAILED]on a bad specget(id)GET /reports/:id[REPORT_NOT_FOUND]delete(id)DELETE /reports/:idrun(id)POST /reports/:id/runschedule(id, opts)POST /reports/:id/schedulerecipients+intervalMinutes/cronExpressionlistSchedules(id)GET /reports/:id/schedules{data}unschedule(scheduleId)DELETE /reports/schedules/:scheduleId204-safe matters:
unwrapResponseparses JSON unconditionally, and both DELETE routes return204 No Content— the new methods short-circuit to{ deleted: true }before any parse, and the tests feed a body-less 204 mock that throws onjson()to prove it.Ledger & docs
gap→sdk; two-sided conformance guard proves each method exists.client-sdk.mdxsurface table gains the reports row.Verification
@objectstack/client: 144/144 (+6 URL-pinning tests), baretscclean.@objectstack/rest: 394/394 (guard green at ratchet 26).🤖 Generated with Claude Code
https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
Generated by Claude Code