Skip to content

Update skrl's agent configurations in the Isaac Lab template#5817

Merged
kellyguo11 merged 1 commit into
isaac-sim:mainfrom
Toni-SM:toni/template_skrl_agent_config
May 28, 2026
Merged

Update skrl's agent configurations in the Isaac Lab template#5817
kellyguo11 merged 1 commit into
isaac-sim:mainfrom
Toni-SM:toni/template_skrl_agent_config

Conversation

@Toni-SM
Copy link
Copy Markdown
Contributor

@Toni-SM Toni-SM commented May 27, 2026

Description

Update skrl's agent configurations in the Isaac Lab template

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@Toni-SM Toni-SM requested a review from hhansen-bdai as a code owner May 27, 2026 20:17
@Toni-SM Toni-SM self-assigned this May 27, 2026
@Toni-SM Toni-SM requested a review from kellyguo11 May 27, 2026 20:17
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Greptile Summary

This PR updates the Isaac Lab template skrl agent configuration files (AMP, IPPO, MAPPO) to align with the current skrl API, renaming and restructuring preprocessor and reward-scale fields.

  • skrl_amp_cfg: Renames state_preprocessorobservation_preprocessor, amp_state_preprocessoramp_observation_preprocessor, task/style_reward_weighttask/style_reward_scale (with style_reward_scale bumped from 1.0 to 2.0), and removes the now-redundant discriminator_reward_scale field.
  • skrl_ippo_cfg: Swaps state_preprocessor: RunningStandardScaler for observation_preprocessor: RunningStandardScaler + an explicit state_preprocessor: null, matching the skrl IPPO API.
  • skrl_mappo_cfg: Corrects the value-model input from OBSERVATIONS to STATES (required for the centralized critic in MAPPO), adds observation_preprocessor, and removes the obsolete shared_state_preprocessor field — all consistent with existing task-level MAPPO configs in the repo.

Confidence Score: 5/5

Safe to merge — all three template configs are updated to match the new skrl API and are already consistent with the actual task-level YAML configs in the repo.

Every changed field in all three templates was cross-validated against both the skrl documentation and the existing production task configs (skrl_walk_amp_cfg.yaml, cart_double_pendulum skrl_mappo/ippo_cfg.yaml, shadow_hand_over skrl_mappo_cfg.yaml). The value model input change in MAPPO from OBSERVATIONS to STATES is semantically correct for the centralized-critic design.

No files require special attention.

Important Files Changed

Filename Overview
tools/template/templates/agents/skrl_amp_cfg Renames state_preprocessor→observation_preprocessor, amp_state_preprocessor→amp_observation_preprocessor, task/style reward weight→scale fields, removes discriminator_reward_scale, and adjusts style_reward_scale from 1.0 to 2.0 — all consistent with the updated skrl AMP API and matching the existing humanoid_amp task configs.
tools/template/templates/agents/skrl_ippo_cfg Replaces state_preprocessor with observation_preprocessor (null state_preprocessor) to match the updated skrl IPPO API; consistent with cart_double_pendulum's skrl_ippo_cfg.yaml.
tools/template/templates/agents/skrl_mappo_cfg Switches value model input from OBSERVATIONS to STATES (correct for centralized MAPPO critics), adds observation_preprocessor, removes shared_state_preprocessor — matches both cart_double_pendulum and shadow_hand_over MAPPO configs.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph AMP["skrl_amp_cfg (AMP agent)"]
        A1[observation_preprocessor: RunningStandardScaler]
        A2[state_preprocessor: null]
        A3[amp_observation_preprocessor: RunningStandardScaler]
        A4[task_reward_scale: 0.0]
        A5[style_reward_scale: 2.0]
    end

    subgraph IPPO["skrl_ippo_cfg (IPPO agent)"]
        B1[observation_preprocessor: RunningStandardScaler]
        B2[state_preprocessor: null]
        B3[value_preprocessor: RunningStandardScaler]
    end

    subgraph MAPPO["skrl_mappo_cfg (MAPPO agent)"]
        C1[Policy model: input=OBSERVATIONS]
        C2[Value model: input=STATES]
        C3[observation_preprocessor: RunningStandardScaler]
        C4[state_preprocessor: RunningStandardScaler]
    end

    AMP -->|"Renamed from state_preprocessor"| A1
    AMP -->|"Renamed from amp_state_preprocessor"| A3
    AMP -->|"Renamed from task/style_reward_weight"| A4
    IPPO -->|"Renamed from state_preprocessor"| B1
    MAPPO -->|"Changed from OBSERVATIONS"| C2
    MAPPO -->|"Added; removed shared_state_preprocessor"| C3
Loading

Reviews (1): Last reviewed commit: "Update skrl's agents configurations in t..." | Re-trigger Greptile

@kellyguo11 kellyguo11 merged commit 84d0ff0 into isaac-sim:main May 28, 2026
9 of 10 checks passed
kellyguo11 added a commit that referenced this pull request May 28, 2026
# Description

Merge changes from main branch:

- #4875 - Adds Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants
- #4909 - Updates minor RSL-RL configclass docstring
- #4934 - Updates Newton docs on main for 3.0 beta changes
- #5182 - Fix flatdict version pin to allow 4.1.0+
- #5195 - Add NCCL troubleshooting notes
- #5406 - Updates doc building job on main to match develop
- #5311 - Update skrl integration for version 2.0.0
- #5482 - Adds nightly-changelog.yml on main
- #5527 - Use isaaclab-bot GitHub App token for nightly changelog push
- #5537 - Address deprecation warnings in nightly changelog workflow
- #5746 - Fix .dockerignore for _isaac_sim symlink
- #5745 - Parameterize nightly compile over configurable branches
- #5546 - Fix swapped preserve_order docstrings
- #5817 - Update skrl agent configurations in the Isaac Lab template
kellyguo11 added a commit to kellyguo11/IsaacLab-public that referenced this pull request May 28, 2026
# Description

Merge changes from main branch:

- isaac-sim#4875 - Adds Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants
- isaac-sim#4909 - Updates minor RSL-RL configclass docstring
- isaac-sim#4934 - Updates Newton docs on main for 3.0 beta changes
- isaac-sim#5182 - Fix flatdict version pin to allow 4.1.0+
- isaac-sim#5195 - Add NCCL troubleshooting notes
- isaac-sim#5406 - Updates doc building job on main to match develop
- isaac-sim#5311 - Update skrl integration for version 2.0.0
- isaac-sim#5482 - Adds nightly-changelog.yml on main
- isaac-sim#5527 - Use isaaclab-bot GitHub App token for nightly changelog push
- isaac-sim#5537 - Address deprecation warnings in nightly changelog workflow
- isaac-sim#5746 - Fix .dockerignore for _isaac_sim symlink
- isaac-sim#5745 - Parameterize nightly compile over configurable branches
- isaac-sim#5546 - Fix swapped preserve_order docstrings
- isaac-sim#5817 - Update skrl agent configurations in the Isaac Lab template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants