Merges changes from main#5824
Conversation
Greptile SummaryThis PR merges a batch of improvements from
Confidence Score: 4/5Safe to merge; all functional changes are well-reasoned and the workflow refactor includes good security practices around token scope and branch-name injection. The only finding is a mismatch between the secret name documented in the header comment (
Important Files Changed
Sequence DiagramsequenceDiagram
participant Cron as GitHub Scheduler / workflow_dispatch
participant Resolve as resolve-branches job
participant Matrix as compile-changelog (matrix)
participant AppToken as actions/create-github-app-token
participant Checkout as actions/checkout
participant Compile as tools/changelog/cli.py
participant Remote as GitHub remote (target branch)
Cron->>Resolve: trigger (schedule → CRON_BRANCHES CSV, dispatch → single branch input)
Resolve->>Resolve: "CSV → JSON array, validate dispatch=1 branch"
Resolve-->>Matrix: branches JSON array
loop for each branch in matrix
Matrix->>AppToken: mint short-lived token (CHANGELOG_APP_CLIENT_ID + CHANGELOG_APP_PRIVATE_KEY)
AppToken-->>Matrix: installation token (1 h)
Matrix->>Checkout: checkout matrix.branch with App token
Matrix->>Matrix: verify tools/changelog/cli.py exists
Matrix->>Compile: python3 cli.py compile [--dry-run]
alt "fragments compiled & not dry_run"
Matrix->>Remote: git pull --rebase refs/heads/$TARGET_BRANCH
Matrix->>Remote: git push HEAD:refs/heads/$TARGET_BRANCH
else no fragments or dry_run
Matrix->>Matrix: skip commit/push
end
end
Reviews (1): Last reviewed commit: "Merges changes from main" | Re-trigger Greptile |
| # | ||
| # The push uses a short-lived GitHub App installation token minted from | ||
| # ``CHANGELOG_APP_ID`` + ``CHANGELOG_APP_PRIVATE_KEY`` (repo secrets). The |
There was a problem hiding this comment.
Secret name mismatch in header comment
The header comment documents the required secrets as CHANGELOG_APP_ID + CHANGELOG_APP_PRIVATE_KEY, but the action on line 134 actually reads from CHANGELOG_APP_CLIENT_ID + CHANGELOG_APP_PRIVATE_KEY. A maintainer following the comment to configure the repo secrets would create CHANGELOG_APP_ID instead of CHANGELOG_APP_CLIENT_ID, and the token-mint step would silently fail to find the secret.
# Description Merge changes from main branch: - isaac-sim#4875 - Adds Isaac-Stack-Cube-Franka-IK-Rel-v0 task variants - isaac-sim#4909 - Updates minor RSL-RL configclass docstring - isaac-sim#4934 - Updates Newton docs on main for 3.0 beta changes - isaac-sim#5182 - Fix flatdict version pin to allow 4.1.0+ - isaac-sim#5195 - Add NCCL troubleshooting notes - isaac-sim#5406 - Updates doc building job on main to match develop - isaac-sim#5311 - Update skrl integration for version 2.0.0 - isaac-sim#5482 - Adds nightly-changelog.yml on main - isaac-sim#5527 - Use isaaclab-bot GitHub App token for nightly changelog push - isaac-sim#5537 - Address deprecation warnings in nightly changelog workflow - isaac-sim#5746 - Fix .dockerignore for _isaac_sim symlink - isaac-sim#5745 - Parameterize nightly compile over configurable branches - isaac-sim#5546 - Fix swapped preserve_order docstrings - isaac-sim#5817 - Update skrl agent configurations in the Isaac Lab template
… teleop/mimic dependency (#5829) # Description Cherry pick bug fix PRs from develop: - #5821 - #5820 - #5733 - #5824 --------- Signed-off-by: peterd-NV <peterd@nvidia.com> Co-authored-by: peterd-NV <peterd@nvidia.com> Co-authored-by: ooctipus <zhengyuz@nvidia.com> Co-authored-by: matthewtrepte <mtrepte@nvidia.com>
Description
Merge changes from main branch: