chore: strip stale #[allow(dead_code)] from live functions#1340
Open
jwiegley wants to merge 1 commit into
Open
chore: strip stale #[allow(dead_code)] from live functions#1340jwiegley wants to merge 1 commit into
jwiegley wants to merge 1 commit into
Conversation
This was referenced May 11, 2026
Contributor
Author
7fdd403 to
9147d02
Compare
4b5f4e9 to
2a3ff6e
Compare
9147d02 to
8780647
Compare
5166dbc to
bc3f93c
Compare
These suppressions were correct when originally added but became stale as call sites were added or tests were written. The functions they cover are now reachable: log_message (bash_tool, git_ai_handlers, upgrade), with_warning (install_hooks tests), notes_add_blob_batch and get_reference_as_working_log (refs_unit tests), persist_file_version (repo_storage_unit tests), Blob::id and remote_head and push_authorship and get_file_content and from_bare_repository (repository callers), CiContext::with_repository (ci_context_unit tests), and AttributionTracker::with_config (attribution_tracker tests). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
bc3f93c to
8e9d328
Compare
2a9a1ca to
a085b70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
These suppressions were correct when added but became stale as callers were added or tests were written. Affects: log_message, with_warning, notes_add_blob_batch, get_reference_as_working_log, persist_file_version, Blob::id, remote_head, push_authorship, get_file_content, from_bare_repository, CiContext::with_repository, AttributionTracker::with_config.
Test plan
task buildpassestask lintpasses🤖 Generated with Claude Code