chore(metrics): remove dead null-setter builder methods#1337
Open
jwiegley wants to merge 1 commit into
Open
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This was referenced May 11, 2026
Contributor
Author
This was referenced May 11, 2026
jwiegley
force-pushed
the
dc/git-diff-tree-cleanup
branch
from
5c54e93 to
c5aad7a
Compare
jwiegley
force-pushed
the
dc/metrics-null-builders-cleanup
branch
2 times, most recently
from
2c4e995 to
8bbf005
Compare
jwiegley
force-pushed
the
dc/git-diff-tree-cleanup
branch
2 times, most recently
from
906017f to
27c3eee
Compare
jwiegley
force-pushed
the
dc/metrics-null-builders-cleanup
branch
from
8bbf005 to
21c1a42
Compare
EventAttributes, CommittedValues, and CheckpointValues each had a set of *_null() methods for setting sparse-encoded fields to Some(None). Those with zero callers outside their own unit tests are removed along with the tests that exclusively covered them. Methods called from production code (post_commit.rs, install_hooks.rs) are retained. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
dc/git-diff-tree-cleanup
branch
from
27c3eee to
d4ae464
Compare
jwiegley
force-pushed
the
dc/metrics-null-builders-cleanup
branch
from
21c1a42 to
d13815d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventAttributes, CommittedValues, and CheckpointValues each had *_null() methods for sparse-encoding fields as Some(None). Methods with zero production callers are removed along with their tests. Methods called from production code (post_commit.rs, install_hooks.rs) are retained.
Test plan
task buildpassestask lintpasses🤖 Generated with Claude Code