chore(authorship): remove 3 dead methods from authorship_log_serialization#1332
Open
jwiegley wants to merge 1 commit into
Open
chore(authorship): remove 3 dead methods from authorship_log_serialization#1332jwiegley wants to merge 1 commit into
jwiegley wants to merge 1 commit into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
3 tasks
Contributor
Author
This was referenced May 11, 2026
jwiegley
force-pushed
the
dc/authorship-serialization-cleanup
branch
2 times, most recently
from
e0142df to
4f7a1d2
Compare
jwiegley
force-pushed
the
dc/api-client-cleanup
branch
2 times, most recently
from
398e699 to
5b6c496
Compare
jwiegley
force-pushed
the
dc/authorship-serialization-cleanup
branch
from
4f7a1d2 to
233d28d
Compare
…ation AttestationEntry::remove_line_ranges, AttestationEntry::shift_line_ranges, and AuthorshipLog::convert_to_checkpoints_for_squash had zero callers. The squash-merge authorship path was refactored into rebase_authorship.rs; these methods were never updated to reflect that. Also removes the private compress_lines_to_working_log_format helper that only served them, and the six unit tests that exclusively covered this dead code. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jwiegley
force-pushed
the
dc/api-client-cleanup
branch
from
5b6c496 to
7f15079
Compare
jwiegley
force-pushed
the
dc/authorship-serialization-cleanup
branch
from
233d28d to
699f929
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove AttestationEntry::remove_line_ranges, shift_line_ranges, and AuthorshipLog::convert_to_checkpoints_for_squash. The squash-merge authorship path was refactored into rebase_authorship.rs; these methods were never updated. Includes the private compress_lines_to_working_log_format helper and 6 unit tests that exclusively covered the dead code. Net: −611 lines.
Test plan
task buildpassestask lintpasses🤖 Generated with Claude Code