Skip to content

chore(api): remove dead bundle module and CAS read endpoint#1330

Open
jwiegley wants to merge 1 commit into
mainfrom
dc/api-bundle-cas-cleanup
Open

chore(api): remove dead bundle module and CAS read endpoint#1330
jwiegley wants to merge 1 commit into
mainfrom
dc/api-bundle-cas-cleanup

Conversation

@jwiegley
Copy link
Copy Markdown
Contributor

@jwiegley jwiegley commented May 11, 2026

Summary

  • Deletes src/api/bundle.rs entirely — ApiClient::create_bundle was never called from any production code path or test
  • Removes ApiClient::read_ca_prompt_store from src/api/cas.rs — zero callers
  • Removes the types that exclusively served these dead endpoints: BundleData, CreateBundleRequest, CreateBundleResponse, CasMessagesObject, CAPromptStoreReadResult, CAPromptStoreReadResponse
  • Removes unit tests that exclusively covered the deleted code

Test plan

  • task build passes
  • task lint passes
  • No callers of removed symbols exist: grep -rn "create_bundle\|BundleData\|CreateBundleRequest\|read_ca_prompt_store\|CAPromptStore\|CasMessages" src/ tests/ returns zero hits

🤖 Generated with Claude Code


Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@jwiegley jwiegley changed the base branch from johnw/dead-code to graphite-base/1330 May 11, 2026 20:42
@jwiegley jwiegley changed the base branch from graphite-base/1330 to main May 11, 2026 20:42
ApiClient::create_bundle (api/bundle.rs) and
ApiClient::read_ca_prompt_store (api/cas.rs) were never called from any
production code path or test. Remove both implementations along with the
types they exclusively required (BundleData, CreateBundleRequest,
CreateBundleResponse, CasMessagesObject, CAPromptStoreReadResult,
CAPromptStoreReadResponse) and their unit tests.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@jwiegley jwiegley force-pushed the dc/api-bundle-cas-cleanup branch from 254052f to 1f6cf1a Compare May 28, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant