Skip to content

[eas-build-job] Add refreshAdHocProvisioningProfile to iOS job#3717

Merged
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow
May 25, 2026
Merged

[eas-build-job] Add refreshAdHocProvisioningProfile to iOS job#3717
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow

Conversation

@sswrk
Copy link
Copy Markdown
Contributor

@sswrk sswrk commented May 12, 2026

Why

ENG-21094 needs a job field to carry ad-hoc provisioning profile refresh intent for git-based/workflow builds; #3716 added CLI behavior on eas build; this PR is schema-only.

How

Updated packages/eas-build-job/src/ios.ts interface + Joi schema.

Test Plan

cd packages/eas-build-job && yarn test src/__tests__/ios.test.ts
yarn typecheck

@linear
Copy link
Copy Markdown

linear Bot commented May 12, 2026

ENG-21094

Copy link
Copy Markdown
Contributor Author

sswrk commented May 12, 2026

@sswrk sswrk force-pushed the szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in branch from a0fd583 to 5896f86 Compare May 12, 2026 19:13
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from a13488b to ae39cbd Compare May 12, 2026 19:13
@sswrk sswrk force-pushed the szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in branch from 5896f86 to 6a7e606 Compare May 12, 2026 19:20
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from ae39cbd to 18a2e55 Compare May 12, 2026 19:20
@codecov
Copy link
Copy Markdown

codecov Bot commented May 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.17%. Comparing base (17eb5f0) to head (d47c86d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3717   +/-   ##
=======================================
  Coverage   57.17%   57.17%           
=======================================
  Files         905      905           
  Lines       39283    39283           
  Branches     8230     8230           
=======================================
  Hits        22455    22455           
  Misses      15356    15356           
  Partials     1472     1472           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk sswrk force-pushed the szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in branch from 6a7e606 to 3ace75d Compare May 12, 2026 19:36
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from 18a2e55 to 4509f56 Compare May 12, 2026 19:36
@sswrk sswrk force-pushed the szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in branch from 3ace75d to cf3043f Compare May 12, 2026 19:53
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from 4509f56 to 4352dfe Compare May 12, 2026 19:53
@sswrk sswrk force-pushed the szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in branch from cf3043f to b9c092e Compare May 12, 2026 19:56
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from 4352dfe to 9bf6b62 Compare May 12, 2026 19:56
@sswrk sswrk changed the base branch from szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in to graphite-base/3717 May 18, 2026 13:03
@sswrk sswrk force-pushed the graphite-base/3717 branch from b9c092e to 701b7d7 Compare May 20, 2026 11:43
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from 9bf6b62 to 14bf3aa Compare May 20, 2026 11:43
@sswrk sswrk changed the base branch from graphite-base/3717 to szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in May 20, 2026 11:43
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from 14bf3aa to 368552c Compare May 20, 2026 11:57
@sswrk sswrk force-pushed the szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in branch from 701b7d7 to 4c939d9 Compare May 20, 2026 11:57
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch 2 times, most recently from 101acdf to c9227ea Compare May 21, 2026 11:37
@sswrk sswrk force-pushed the szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in branch from d20291d to d4b4bf6 Compare May 21, 2026 11:37
@sswrk sswrk changed the title [build-tools] Pass refresh ad-hoc provisioning profile through build:internal [build-tools][eas-build-job] Pass refresh ad-hoc provisioning profile through build:internal May 21, 2026
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch 2 times, most recently from b33de40 to 21d23de Compare May 21, 2026 12:29
@sswrk sswrk changed the title [build-tools][eas-build-job] Pass refresh ad-hoc provisioning profile through build:internal [eas-build-job] Add refresh_ad_hoc_provisioning_profile to iOS job May 21, 2026
@sswrk sswrk changed the title [eas-build-job] Add refresh_ad_hoc_provisioning_profile to iOS job [eas-build-job] Add refresh_ad_hoc_provisioning_profile to iOS job May 21, 2026
@sswrk sswrk marked this pull request as ready for review May 21, 2026 12:53
@sswrk sswrk requested a review from sjchmiela May 21, 2026 12:54
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sswrk sswrk changed the base branch from szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in to graphite-base/3717 May 22, 2026 08:41
@sswrk sswrk force-pushed the graphite-base/3717 branch from 588f136 to fce2a77 Compare May 22, 2026 08:41
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from 21d23de to f0d024b Compare May 22, 2026 08:41
@graphite-app graphite-app Bot changed the base branch from graphite-base/3717 to main May 22, 2026 08:42
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from f0d024b to c04b2e1 Compare May 22, 2026 08:42
Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was dreaming we finally moved from joi to zod but looks like it was just a dream lol

Comment thread packages/eas-build-job/src/ios.ts Outdated
@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from c04b2e1 to d47c86d Compare May 25, 2026 07:15
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@sswrk sswrk changed the title [eas-build-job] Add refresh_ad_hoc_provisioning_profile to iOS job [eas-build-job] Add refreshAdHocProvisioningProfile to iOS job May 25, 2026
@sswrk sswrk merged commit 43ffe46 into main May 25, 2026
11 checks passed
@sswrk sswrk deleted the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch May 25, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants