[eas-cli] Add --refresh-ad-hoc-provisioning-profile for non-interactive builds#3716
Merged
sswrk merged 6 commits intoMay 22, 2026
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sswrk
force-pushed
the
szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in
branch
2 times, most recently
from
5896f86 to
6a7e606
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3716 +/- ##
==========================================
+ Coverage 56.80% 56.88% +0.09%
==========================================
Files 904 904
Lines 39112 39177 +65
Branches 8173 8202 +29
==========================================
+ Hits 22214 22283 +69
+ Misses 15428 15422 -6
- Partials 1470 1472 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sswrk
force-pushed
the
szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in
branch
from
6a7e606 to
3ace75d
Compare
sswrk
changed the title
--refresh-ad-hoc-provisioning-profile for non-interactive builds
sswrk
force-pushed
the
szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in
branch
2 times, most recently
from
cf3043f to
b9c092e
Compare
|
Subscribed to pull request
Generated by CodeMention |
sswrk
force-pushed
the
szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in
branch
from
b9c092e to
98ce5be
Compare
sjchmiela
approved these changes
May 19, 2026
Contributor
sjchmiela
left a comment
sjchmiela
left a comment
There was a problem hiding this comment.
this looks good to me, but i'd also wait for Quin to take a look
quinlanj
requested changes
May 20, 2026
Member
quinlanj
left a comment
quinlanj
left a comment
There was a problem hiding this comment.
requesting changes because we should filter devices based on the target type
sswrk
force-pushed
the
szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in
branch
2 times, most recently
from
701b7d7 to
4c939d9
Compare
quinlanj
approved these changes
May 20, 2026
…f the refresh adhoc profile flag
…tore auth context
sswrk
force-pushed
the
szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in
branch
from
d20291d to
d4b4bf6
Compare
|
✅ Thank you for adding the changelog entry! |
This was referenced May 21, 2026
sswrk
deleted the
szymonswierk/eng-7041-allow-including-all-eas-registered-devices-automatically-in
branch
sswrk
added a commit
that referenced
this pull request
May 25, 2026
<!-- If this PR requires a changelog entry, add it by commenting the PR with the command `/changelog-entry [breaking-change|new-feature|bug-fix|chore] [message]`. --> <!-- You can skip the changelog check by labeling the PR with "no changelog". --> # Why ENG-21094 needs a job field to carry ad-hoc provisioning profile refresh intent for git-based/workflow builds; #3716 added CLI behavior on eas build; this PR is schema-only. # How Updated `packages/eas-build-job/src/ios.ts` interface + Joi schema. # Test Plan `cd packages/eas-build-job && yarn test src/__tests__/ios.test.ts` `yarn typecheck`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When a new device is added to an account, and a non-interactive development build is run (e.g. invoked by CI or by a workflow job), even without the
freeze-credentialsflag, the provisioning profile is not refreshed, and the internal build is not available for the newly registered device. See the Linear issue: https://linear.app/expo/issue/ENG-7041/allow-including-all-eas-registered-devices-automatically-in-nonHow
Added an opt-in ad-hoc provisioning profile refresh to non-interactive builds with flag
--refresh-ad-hoc-provisioning-profile.When the flag is present, we hit
wwwGQL API to get the ASC API key (the submission key), and we invoke the ad-hoc profile sync with all devices selected.packages/eas-cli/src/credentials/ios/actions/SetUpAdhocProvisioningProfile.tsis where this logic happens.The flag mustn't be present when
--freeze-credentialsis present, these are conflicting flags.I'm leaning towards an opt-in flag instead of extending the default behavior because of the extra credentials configuration requirements and side effects of the provisioning profile refresh logic.
Test Plan
Added/amended tests.
Manual verification:
easd build --platform ios --profile development --non-interactive --refresh-ad-hoc-credential, verified the provisioning profile matches the set of Apple devices on my account.easd build --platform ios --profile development --non-interactive --refresh-ad-hoc-credentialagain, verified the re-generated provisioning profile matches the Apple devices on my account.