Skip to content

[eas-cli] Wire refresh ad-hoc profile through build:internal and prepareJob#3769

Merged
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-21094-cli-build-internal-refresh
May 25, 2026
Merged

[eas-cli] Wire refresh ad-hoc profile through build:internal and prepareJob#3769
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-21094-cli-build-internal-refresh

Conversation

@sswrk
Copy link
Copy Markdown
Contributor

@sswrk sswrk commented May 21, 2026

Why

Workflow builds run eas build:internal on EAS workers to resolve credentials and emit the job JSON. The base branch adds --refresh-ad-hoc-provisioning-profile to eas build, but that flag was not available on build:internal, and the iOS job did not persist refresh_ad_hoc_provisioning_profile when the flag was set.

Without this wiring, git-based/workflow builds could not trigger ad-hoc profile refresh or pass the intent through to the job payload.

How

  • Add --refresh-ad-hoc-provisioning-profile to eas build:internal and pass it into runBuildAndSubmitAsync (same behavior as eas build).
  • In prepareJob.ts, set refresh_ad_hoc_provisioning_profile: true on the iOS job when the credentials context has the flag enabled.

Test Plan

yarn typecheck

@linear
Copy link
Copy Markdown

linear Bot commented May 21, 2026

ENG-21094

Copy link
Copy Markdown
Contributor Author

sswrk commented May 21, 2026

@sswrk sswrk changed the title [eas-cli] Wire refresh ad-hoc profile through build:internal and prepareJob [eas-cli] Wire refresh ad-hoc profile through build:internal and prepareJob May 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.17%. Comparing base (43ffe46) to head (148241d).

Files with missing lines Patch % Lines
packages/eas-cli/src/build/ios/prepareJob.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3769      +/-   ##
==========================================
- Coverage   57.17%   57.17%   -0.00%     
==========================================
  Files         905      905              
  Lines       39283    39284       +1     
  Branches     8230     8231       +1     
==========================================
  Hits        22455    22455              
- Misses      15356    15357       +1     
  Partials     1472     1472              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch from 10da52d to 20da401 Compare May 21, 2026 12:41
@sswrk sswrk added the no changelog PR that doesn't require a changelog entry label May 21, 2026
@sswrk sswrk marked this pull request as ready for review May 21, 2026 12:58
@sswrk sswrk requested a review from sjchmiela May 21, 2026 12:58
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder
packages/eas-cli/src/commands/build/** @sjchmiela
packages/eas-cli/src/build/** @sjchmiela

Generated by CodeMention

@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch 2 times, most recently from f0d024b to c04b2e1 Compare May 22, 2026 08:42
@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch from 20da401 to 32dbe0c Compare May 22, 2026 08:42
Copy link
Copy Markdown
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gosh i hate this

@sswrk sswrk force-pushed the szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow branch from c04b2e1 to d47c86d Compare May 25, 2026 07:15
@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch from 32dbe0c to 89ed6ab Compare May 25, 2026 07:15
@sswrk sswrk changed the base branch from szymonswierk/eng-21094-allow-regenerating-ad-hoc-provisioning-profiles-in-workflow to graphite-base/3769 May 25, 2026 09:43
@sswrk sswrk force-pushed the graphite-base/3769 branch from d47c86d to 43ffe46 Compare May 25, 2026 09:43
@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch from 89ed6ab to f997360 Compare May 25, 2026 09:43
@graphite-app graphite-app Bot changed the base branch from graphite-base/3769 to main May 25, 2026 09:43
@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch from f997360 to 148241d Compare May 25, 2026 09:43
@github-actions
Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sswrk sswrk merged commit 18c2e82 into main May 25, 2026
11 checks passed
@sswrk sswrk deleted the szymonswierk/eng-21094-cli-build-internal-refresh branch May 25, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants