Skip to content

[build-tools] Pass refresh ad-hoc provisioning profile through build:internal#3770

Merged
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-21094-build-tools-refresh
May 25, 2026
Merged

[build-tools] Pass refresh ad-hoc provisioning profile through build:internal#3770
sswrk merged 1 commit into
mainfrom
szymonswierk/eng-21094-build-tools-refresh

Conversation

@sswrk
Copy link
Copy Markdown
Contributor

@sswrk sswrk commented May 21, 2026

Why

Git-based integration builds call eas build:internal via runEasBuildInternalAsync. The refresh flag must reach the CLI and remain on the job object returned to the rest of the build.

How

Forward --refresh-ad-hoc-provisioning-profile when set on the iOS job; retain refresh_ad_hoc_provisioning_profile in validateEasBuildInternalResult.

Test Plan

cd packages/build-tools && yarn test src/common/__tests__/easBuildInternal.test.ts

@linear
Copy link
Copy Markdown

linear Bot commented May 21, 2026

ENG-21094

Copy link
Copy Markdown
Contributor Author

sswrk commented May 21, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 57.21%. Comparing base (18c2e82) to head (23ea212).

Files with missing lines Patch % Lines
...ackages/build-tools/src/common/easBuildInternal.ts 85.72% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3770      +/-   ##
==========================================
+ Coverage   57.17%   57.21%   +0.05%     
==========================================
  Files         905      905              
  Lines       39284    39290       +6     
  Branches     8231     8235       +4     
==========================================
+ Hits        22455    22475      +20     
+ Misses      15357    15345      -12     
+ Partials     1472     1470       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch from 10da52d to 20da401 Compare May 21, 2026 12:41
@sswrk sswrk force-pushed the szymonswierk/eng-21094-build-tools-refresh branch 2 times, most recently from d91ca7e to 67b630b Compare May 21, 2026 12:43
@sswrk sswrk marked this pull request as ready for review May 21, 2026 13:06
@sswrk sswrk requested a review from sjchmiela May 21, 2026 13:06
@github-actions
Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch from 20da401 to 32dbe0c Compare May 22, 2026 08:42
@sswrk sswrk force-pushed the szymonswierk/eng-21094-build-tools-refresh branch from 67b630b to 2a97e3f Compare May 22, 2026 08:43
Comment thread packages/build-tools/src/common/easBuildInternal.ts Outdated
@sswrk sswrk force-pushed the szymonswierk/eng-21094-build-tools-refresh branch from 2a97e3f to d22e0b7 Compare May 25, 2026 07:15
@sswrk sswrk force-pushed the szymonswierk/eng-21094-cli-build-internal-refresh branch 3 times, most recently from f997360 to 148241d Compare May 25, 2026 09:43
@sswrk sswrk force-pushed the szymonswierk/eng-21094-build-tools-refresh branch from d22e0b7 to 3790c28 Compare May 25, 2026 09:43
@sswrk sswrk changed the base branch from szymonswierk/eng-21094-cli-build-internal-refresh to graphite-base/3770 May 25, 2026 09:49
@sswrk sswrk force-pushed the szymonswierk/eng-21094-build-tools-refresh branch from 3790c28 to a550ac8 Compare May 25, 2026 09:49
@sswrk sswrk force-pushed the graphite-base/3770 branch from 148241d to 18c2e82 Compare May 25, 2026 09:49
@graphite-app graphite-app Bot changed the base branch from graphite-base/3770 to main May 25, 2026 09:50
@sswrk sswrk force-pushed the szymonswierk/eng-21094-build-tools-refresh branch from a550ac8 to 097d693 Compare May 25, 2026 09:50
@sswrk sswrk force-pushed the szymonswierk/eng-21094-build-tools-refresh branch from 097d693 to 23ea212 Compare May 25, 2026 10:02
@github-actions
Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@sswrk sswrk merged commit 149f5d8 into main May 25, 2026
11 checks passed
@sswrk sswrk deleted the szymonswierk/eng-21094-build-tools-refresh branch May 25, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants