Skip to content

Fix: Robust LangChain Provider String Handling#1253

Open
Kaweees wants to merge 5 commits intodevfrom
miguel/langchain_provider_fix
Open

Fix: Robust LangChain Provider String Handling#1253
Kaweees wants to merge 5 commits intodevfrom
miguel/langchain_provider_fix

Conversation

@Kaweees
Copy link
Member

@Kaweees Kaweees commented Feb 13, 2026

This merge request fixes provider string formatting issues when initializing LangChain chat models such that values are correctly passed to init_chat_model.

Quick Start

uv run dimos run unitree-go2-agentic

@greptile-apps
Copy link

greptile-apps bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

Updated MCP README documentation to fix the Claude Code setup command and usage instructions. The changes improve the setup process by using uv run python -m dimos.protocol.mcp instead of direct Python invocation, and update the example usage to use dimos --replay run unitree-go2-agentic instead of the -mcp variant blueprint. Also improved markdown formatting with better spacing and proper code fence language specification.

  • Updated Claude Code integration command to use uv run python for proper environment isolation
  • Changed usage example from unitree-go2-agentic-mcp to standard unitree-go2-agentic blueprint with --replay flag
  • Improved document formatting with additional blank lines and text language specification for code blocks

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • Documentation-only change that updates MCP README with correct commands verified to exist in the codebase - the --replay flag and unitree-go2-agentic blueprint are both valid and widely used throughout the project
  • No files require special attention

Important Files Changed

Filename Overview
dimos/protocol/mcp/README.md Updated MCP setup instructions to use uv run python and changed usage example from unitree-go2-agentic-mcp to dimos --replay run unitree-go2-agentic, improved formatting with better spacing and text code fence

Last reviewed commit: 496dce8

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps
Copy link

greptile-apps bot commented Feb 13, 2026

Additional Comments (2)

dimos/agents/llm_init.py
.lower() is now redundant since config.provider.value returns lowercase strings after the enum change

    if config.provider.value == "ollama":

dimos/agents/llm_init.py
.lower() is now redundant since config.provider.value returns lowercase strings after the enum change

    if config.provider.value == "huggingface":

@Kaweees Kaweees changed the title Fix: pass the right provider string to LangChain Fix: Fix LangChain Provider String Handling Feb 13, 2026
@Kaweees
Copy link
Member Author

Kaweees commented Feb 13, 2026

@greptile

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@Kaweees Kaweees force-pushed the miguel/langchain_provider_fix branch from 496dce8 to 60a3453 Compare February 13, 2026 21:54
@Kaweees Kaweees force-pushed the miguel/langchain_provider_fix branch from 60a3453 to 2e68dd7 Compare February 13, 2026 22:00
@spomichter
Copy link
Contributor

Ah shit @paul-nechifor @Kaweees FYI - Paul did a major agent refactor and deleted most of the files that you were changing in this PR. Will need to be re-fixed

@Kaweees Kaweees changed the title Fix: Fix LangChain Provider String Handling Fix: Robust LangChain Provider String Handling Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments