Enable SwiftLint rule: unused_closure_parameter by mokagio · Pull Request #25517 · wordpress-mobile/WordPress-iOS

mokagio · 2026-05-04T02:47:13Z

What

Enables the SwiftLint unused_closure_parameter rule, which flags closure parameters that are never referenced and recommends replacing them with _.

Stats

Auto-fixed violations: 340 across 167 files
Manual fixes: 0
swiftlint:disable additions: 0

The rule is autocorrectable and the substitution (name → _) is type-preserving, so no manual intervention or build breakage was expected or observed.

Testing

bundle exec rake lint is clean on the modified config.
Build/test deferred to CI per campaign convention for type-preserving rules.

Part of the Orchard SwiftLint rollout campaign.

Adds `unused_closure_parameter` to `.swiftlint.yml`'s `only_rules` and applies SwiftLint's autocorrection across the codebase. 340 violations were autofixed across 167 files; no manual fixes or `swiftlint:disable` comments were needed. Part of the Orchard SwiftLint rollout campaign. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Code Opus 4.7 (1M context) <noreply@anthropic.com>

dangermattic · 2026-05-04T02:47:44Z

	2 Warnings
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

Copilot

Pull request overview

This PR enables SwiftLint’s unused_closure_parameter rule across the iOS codebase and applies the corresponding mechanical cleanup so unused closure arguments are replaced with _. It fits the repository’s incremental lint-rollout approach by updating both product and test code to conform to a newly enabled opt-in rule.

Changes:

Enable the unused_closure_parameter SwiftLint rule in .swiftlint.yml.
Autocorrect unused closure parameters across app, module, share-extension, and support code.
Update affected tests and UI test helpers so the repo stays lint-clean after the rule is enabled.

Reviewed changes

Copilot reviewed 167 out of 167 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
WordPress/WordPressShareExtension/Sources/UI/ShareModularViewController.swift	Replaces unused alert-action closure parameters with `_`.
WordPress/WordPressShareExtension/Sources/UI/ShareExtensionEditorViewController.swift	Cleans unused closure args in editor alerts/action sheets.
WordPress/WordPressShareExtension/Sources/UI/ShareExtensionAbstractViewController.swift	Cleans unused alert action parameter.
WordPress/WordPressShareExtension/Sources/Services/ShareExtractor.swift	Cleans unused async callback parameters in share extraction.
WordPress/WordPressShareExtension/Sources/Services/AppExtensionsService.swift	Replaces unused media-update success parameter.
WordPress/WordPressScreenshotGeneration/SnapshotHelper.swift	Replaces unused renderer context parameter.
WordPress/WordPressNotificationServiceExtension/Sources/NotificationService.swift	Replaces unused URLSession error parameter.
WordPress/Classes/ViewRelated/Views/RichTextView/NSAttributedString+RichTextView.swift	Replaces unused attachment enumeration stop pointer.
WordPress/Classes/ViewRelated/Themes/ThemeBrowserViewController.swift	Cleans unused theme-sync and alert handler params.
WordPress/Classes/ViewRelated/Themes/ThemeBrowserCell.swift	Cleans unused action handler parameter.
WordPress/Classes/ViewRelated/System/Notices/NoticePresenter.swift	Replaces unused local-notification completion error.
WordPress/Classes/ViewRelated/System/Floating Create Button/CreateButtonCoordinator.swift	Cleans unused sheet/animation callback parameters.
WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift	Replaces unused table-row action parameters.
WordPress/Classes/ViewRelated/Support/SupportChatBot/SupportChatBotViewController.swift	Replaces unused JS-evaluation result parameter.
WordPress/Classes/ViewRelated/Stats/Subscribers/StatsSubscribersStore.swift	Replaces unused stats-service error parameter.
WordPress/Classes/ViewRelated/Stats/SiteStatsDashboardViewController.swift	Cleans unused KVO observed object parameter.
WordPress/Classes/ViewRelated/Stats/Shared Views/Stats Detail/SiteStatsInsightsDetailsViewModel.swift	Replaces unused status closure parameters.
WordPress/Classes/ViewRelated/Stats/Insights/Insights Management/InsightsManagementViewController.swift	Replaces unused row action parameter.
WordPress/Classes/ViewRelated/Reader/Subscriptions/ReaderSubscriptionHelper.swift	Replaces unused failure error parameter.
WordPress/Classes/ViewRelated/Reader/Detail/Views/ReaderDetailToolbar.swift	Cleans unused observed post parameter.
WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift	Replaces unused JS-evaluation error parameter.
WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailCoordinator.swift	Replaces unused totalLikes parameter.
WordPress/Classes/ViewRelated/Reader/Controllers/ReaderStreamViewController.swift	Cleans unused callback parameters across reader flows.
WordPress/Classes/ViewRelated/Reader/Controllers/ReaderStreamViewController+Sharing.swift	Replaces unused share completion items/error parameters.
WordPress/Classes/ViewRelated/Reader/Controllers/ReaderPostActions/ReaderSubscribeCommentsAction.swift	Replaces unused undo callback result parameter.
WordPress/Classes/ViewRelated/Reader/Comments/ReaderCommentsFollowPresenter.swift	Replaces unused actionable-notice bool parameter.
WordPress/Classes/ViewRelated/QR Login/Helpers/QRLoginCameraPermissionsHandler.swift	Replaces unused settings action parameter.
WordPress/Classes/ViewRelated/QR Login/Coordinators/QRLoginVerifyCoordinator.swift	Replaces unused QR auth callback parameters.
WordPress/Classes/ViewRelated/Post/Search/PostSearchViewController.swift	Replaces unused diffable data source item parameter.
WordPress/Classes/ViewRelated/Post/Publishing/PublishPostViewController.swift	Replaces unused sheet detent resolver parameter.
WordPress/Classes/ViewRelated/Post/PostSharingController.swift	Replaces unused share completion items/error parameters.
WordPress/Classes/ViewRelated/Post/EditPostViewController.swift	Replaces unused auth callback client parameter.
WordPress/Classes/ViewRelated/Post/Categories/PostCategoriesViewController.swift	Replaces unused failure error parameter.
WordPress/Classes/ViewRelated/Plugins/ViewModels/PluginViewModel.swift	Cleans unused alert/coordinator callback parameters.
WordPress/Classes/ViewRelated/Plugins/ViewModels/PluginDirectoryViewModel.swift	Replaces unused action subscription parameter.
WordPress/Classes/ViewRelated/People/Controllers/PersonViewController.swift	Replaces unused alert action parameters.
WordPress/Classes/ViewRelated/People/Controllers/InvitePersonViewController.swift	Replaces unused failure/retry handler parameters.
WordPress/Classes/ViewRelated/Pages/Controllers/PageListViewController.swift	Replaces unused homepage-setting failure parameters.
WordPress/Classes/ViewRelated/Pages/Controllers/EditPageViewController.swift	Replaces unused auth callback client parameter.
WordPress/Classes/ViewRelated/Notifications/Tools/NotificationMediaDownloader.swift	Cleans unused download callback parameters.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController/NotificationsViewController.swift	Replaces unused contextual-action and sync callback parameters.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController+PushPrimer.swift	Replaces unused inline prompt button parameters.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationsViewController+AppRatings.swift	Replaces unused inline prompt button parameters.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationSettingsViewController.swift	Replaces unused alert action parameters.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationSettingDetailsViewController.swift	Replaces unused failure/retry action parameters.
WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationDetailsViewController.swift	Replaces unused transition coordinator context.
WordPress/Classes/ViewRelated/NewGutenberg/NewGutenbergViewController.swift	Replaces unused dismiss action parameter.
WordPress/Classes/ViewRelated/NUX/Controllers/Social Signup/SignupUsernameTableViewController.swift	Replaces unused gesture parameter.
WordPress/Classes/ViewRelated/Media/StockPhotos/DefaultStockPhotosService.swift	Replaces unused network response/error parameters.
WordPress/Classes/ViewRelated/Media/StockPhotos/AztecMediaPickingCoordinator.swift	Replaces unused alert action parameters.
WordPress/Classes/ViewRelated/Media/SiteMedia/Views/SiteMediaCollectionCellViewModel.swift	Replaces unused observed media parameter.
WordPress/Classes/ViewRelated/Media/MediaItemViewController.swift	Replaces unused delete action parameter.
WordPress/Classes/ViewRelated/Me/My Profile/Gravatar/GravatarUploader.swift	Replaces unused upload error parameter.
WordPress/Classes/ViewRelated/Me/Me Main/MeViewController.swift	Replaces unused menu and row action parameters.
WordPress/Classes/ViewRelated/Me/App Settings/MediaCacheSettingsViewController.swift	Replaces unused row/error callback parameters.
WordPress/Classes/ViewRelated/Me/App Settings/AppSettingsViewController.swift	Replaces unused settings row action parameters.
WordPress/Classes/ViewRelated/Me/App Settings/About/AppAboutScreenConfiguration.swift	Replaces unused about-screen action context.
WordPress/Classes/ViewRelated/Me/All Domains/Views/DomainPurchaseChoicesView.swift	Replaces unused dictionary-merging parameter.
WordPress/Classes/ViewRelated/Me/All Domains/Coordinators/AllDomainsAddDomainCoordinator.swift	Replaces unused purchased-domain name parameter.
WordPress/Classes/ViewRelated/Me/Account Settings/AccountSettingsViewController.swift	Replaces unused row and alert action parameters.
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackSettingsViewController.swift	Replaces unused row action parameters.
WordPress/Classes/ViewRelated/Jetpack/Jetpack Settings/JetpackConnectionViewController.swift	Replaces unused row/alert action parameters.
WordPress/Classes/ViewRelated/Gutenberg/Utils/GutenbergMediaEditorImage.swift	Replaces unused image download error parameter.
WordPress/Classes/ViewRelated/Gutenberg/GutenbergViewController.swift	Cleans unused editor/media action parameters.
WordPress/Classes/ViewRelated/Gutenberg/GutenbergNetworking.swift	Replaces unused HTTP response parameters.
WordPress/Classes/ViewRelated/Domains/Domain registration/RegisterDomainSuggestions/RegisterDomainCoordinator.swift	Replaces unused dictionary-merging parameter.
WordPress/Classes/ViewRelated/Domains/Domain registration/RegisterDomainDetails/ViewModel/RegisterDomainDetailsViewModel.swift	Replaces unused failure callback parameters.
WordPress/Classes/ViewRelated/Domains/Domain registration/RegisterDomainDetails/ViewController/RegisterDomainDetailsViewController.swift	Replaces unused gesture parameter.
WordPress/Classes/ViewRelated/Comments/Controllers/EditCommentTableViewController.swift	Replaces unused discard action parameter.
WordPress/Classes/ViewRelated/Comments/Controllers/CommentDetailViewController.swift	Replaces unused failure error parameters.
WordPress/Classes/ViewRelated/Blog/Site Settings/SiteSettingsViewController+Swift.swift	Replaces unused picker enabled parameter.
WordPress/Classes/ViewRelated/Blog/Site Settings/LanguageSelectorViewController.swift	Replaces unused row action parameter.
WordPress/Classes/ViewRelated/Blog/Site Settings/HomepageSettingsViewController.swift	Replaces unused homepage-update failure parameter.
WordPress/Classes/ViewRelated/Blog/Site Settings/DiscussionSettingsViewController.swift	Replaces unused picker enabled parameter.
WordPress/Classes/ViewRelated/Blog/Site Settings/DateAndTimeFormatSettingsViewController.swift	Replaces unused settings row action parameters.
WordPress/Classes/ViewRelated/Blog/Site Monitoring/WebServerLogsView.swift	Replaces unused `onChange` oldValue parameter.
WordPress/Classes/ViewRelated/Blog/Site Monitoring/PHPLogsView.swift	Replaces unused `onChange` oldValue parameter.
WordPress/Classes/ViewRelated/Blog/Sharing/SharingAccountViewController.swift	Replaces unused row action parameter.
WordPress/Classes/ViewRelated/Blog/Onboarding Questions Prompt/OnboardingEnableNotificationsViewController.swift	Replaces unused authorization result parameter.
WordPress/Classes/ViewRelated/Blog/My Site/MySiteViewController.swift	Replaces unused blog-sync failure parameter.
WordPress/Classes/ViewRelated/Blog/My Site/Header/HomeSiteHeaderViewController+SiteIcon.swift	Replaces unused failure/completion parameters.
WordPress/Classes/ViewRelated/Blog/BloggingReminders/BloggingRemindersTracker.swift	Replaces unused dictionary-merging parameter.
WordPress/Classes/ViewRelated/Blog/BloggingReminders/BloggingRemindersFlowSettingsViewController.swift	Replaces unused updated-settings parameter.
WordPress/Classes/ViewRelated/Blog/Blogging Prompts/BloggingPromptCoordinator.swift	Replaces unused scheduling result parameter.
WordPress/Classes/ViewRelated/Blog/Blog Dashboard/Models/DashboardCardModel.swift	Replaces unused dictionary-merging parameter.
WordPress/Classes/ViewRelated/Blog/Blog Dashboard/Helpers/DashboardPostsSyncManager.swift	Replaces unused sync-authors failure parameter.
WordPress/Classes/ViewRelated/Blog/Blog Dashboard/BlogDashboardViewController.swift	Replaces unused compositional-layout environment parameter.
WordPress/Classes/ViewRelated/Aztec/ViewControllers/AztecPostViewController.swift	Cleans unused attachment/action callback parameters.
WordPress/Classes/Utility/ZendeskUtils.swift	Replaces unused failure/newIdentity/pushResponse parameters.
WordPress/Classes/Utility/WPContentSyncHelper.swift	Replaces unused sync failure parameter.
WordPress/Classes/Utility/Sharing/ShareExtensionSessionManager.swift	Replaces unused remote-media success parameter.
WordPress/Classes/Utility/Notifications/PushNotificationsManager.swift	Replaces unused notification sync error parameter.
WordPress/Classes/Utility/Notifications/InteractiveNotificationsManager.swift	Replaces unused failure error parameters.
WordPress/Classes/Utility/Media/MediaVideoExporter.swift	Replaces unused image-generation callback parameters.
WordPress/Classes/Utility/Media/MediaThumbnailExporter.swift	Replaces unused thumbnail identifier parameter.
WordPress/Classes/Utility/In-App Feedback/AppRatingsUtility.swift	Replaces unused default value parameter.
WordPress/Classes/Utility/Blogging Reminders/BloggingRemindersScheduleFormatter.swift	Replaces unused enumeration stop pointer.
WordPress/Classes/Utility/BackgroundTasks/WeeklyRoundupBackgroundTask.swift	Cleans unused closure parameters in roundup helpers.
WordPress/Classes/Users/Views/UserDetailsView.swift	Replaces unused confirmation presentation parameter.
WordPress/Classes/System/WordPressAppDelegate.swift	Replaces unused WP.com sync success account parameter.
WordPress/Classes/System/Root View/RootViewPresenter+AppSettingsNavigation.swift	Replaces unused navigation context parameter.
WordPress/Classes/Stores/PluginStore.swift	Replaces unused plugin-activation failure parameter.
WordPress/Classes/Services/SuggestionService.swift	Replaces unused HTTP response parameter.
WordPress/Classes/Services/SiteSuggestionService.swift	Replaces unused HTTP response parameter.
WordPress/Classes/Services/SiteAssemblyService.swift	Replaces unused assembly failure parameter.
WordPress/Classes/Services/NotificationSettingsService.swift	Replaces unused dictionary-merging parameter.
WordPress/Classes/Services/AuthenticationService.swift	Replaces unused URLSession data parameter.
WordPress/Classes/Login/SelfHostedSiteAuthenticator.swift	Replaces unused ASWebAuthenticationSession error parameter.
WordPress/Classes/Jetpack/JetpackMigration/Common/MigrationEmailService.swift	Replaces unused HTTP response parameters.
Tests/WordPressKitTests/WordPressKitTests/Tests/Utilities/FeatureFlagRemoteTests.swift	Test cleanup for unused response closure parameter.
Tests/WordPressKitTests/WordPressKitTests/Tests/QRLoginServiceRemoteTests.swift	Test cleanup for unused auth/error parameters.
Tests/WordPressKitTests/WordPressKitTests/Tests/IPLocationRemoteTests.swift	Test cleanup for unused request parameter.
Tests/WordPressKitTests/WordPressKitTests/Tests/DomainsServiceRemoteRESTTests.swift	Test cleanup for unused request parameter.
Tests/WordPressKitTests/WordPressKitTests/Tests/DashboardServiceRemoteTests.swift	Test cleanup for unused failure parameter.
Tests/WordPressKitTests/WordPressKitTests/Tests/ActivityServiceRemoteTests.swift	Test cleanup for unused failure parameter.
Tests/WordPressKitTests/CoreAPITests/WordPressOrgXMLRPCApiTests.swift	Test cleanup for unused response objects.
Tests/WordPressKitTests/CoreAPITests/WordPressComRestApiTests.swift	Test cleanup for unused failure error parameter.
Tests/WordPressKitTests/CoreAPITests/WordPressComOAuthClientTests.swift	Test cleanup for unused failure parameter.
Tests/KeystoneTests/Tests/Services/SiteManagementServiceTests.swift	Test cleanup for unused purchases parameter.
Tests/KeystoneTests/Tests/Services/SharingServiceTests.swift	Test cleanup for unused failure parameter.
Tests/KeystoneTests/Tests/Services/PostRepositorySaveTests.swift	Test cleanup for unused request parameters in stubs.
Tests/KeystoneTests/Tests/Services/PostCoordinatorTests.swift	Test cleanup for unused request parameters in stubs.
Tests/KeystoneTests/Tests/Services/PeopleServiceTests.swift	Test cleanup for unused success count parameter.
Tests/KeystoneTests/Tests/Services/NotificationSyncMediatorTests.swift	Test cleanup for unused mark-as-read result parameter.
Tests/KeystoneTests/Tests/Services/NotificationSettingsServiceTests.swift	Test cleanup for unused failure parameter.
Tests/KeystoneTests/Tests/Services/JetpackSocialServiceTests.swift	Test cleanup for unused failure parameter.
Tests/KeystoneTests/Tests/Services/EditorSettingsServiceTests.swift	Test cleanup for unused wait error parameter.
Tests/KeystoneTests/Tests/Services/DomainsServiceTests.swift	Test cleanup for unused refresh result parameter.
Tests/KeystoneTests/Tests/Services/CommentServiceTests.swift	Test cleanup for unused likes callback parameters.
Tests/KeystoneTests/Tests/Services/CommentService+RepliesTests.swift	Test cleanup for unused failure parameter.
Tests/KeystoneTests/Tests/Services/CommentService+LikesTests.swift	Test cleanup for unused failure parameter.
Tests/KeystoneTests/Tests/Services/BloggingPromptsServiceTests.swift	Test cleanup for unused failure parameters.
Tests/KeystoneTests/Tests/Reader/ReaderSubscribeCommentsActionTests.swift	Test cleanup for unused error parameter.
Tests/KeystoneTests/Tests/Networking/RequestAuthenticatorTests.swift	Test cleanup for unused request parameter.
Tests/KeystoneTests/Tests/Networking/MediaRequestAuthenticatorTests.swift	Test cleanup for unused failure parameters.
Tests/KeystoneTests/Tests/Networking/MediaHostTests.swift	Test cleanup for unused completion error parameter.
Tests/KeystoneTests/Tests/Misc/StatsPeriodAsyncOperationTests.swift	Test cleanup for unused error parameter.
Tests/KeystoneTests/Tests/Features/SiteCreation/SiteDesignTests.swift	Test cleanup for unused completion parameter.
Tests/KeystoneTests/Tests/Features/Notifications/TrashCommentActionTests.swift	Test cleanup for unused action-context callback parameters.
Tests/KeystoneTests/Tests/Features/Notifications/PushAuthenticationServiceTests.swift	Test cleanup for unused completion parameter.
Tests/KeystoneTests/Tests/Features/Notifications/MarkAsSpamActionTests.swift	Test cleanup for unused action-context callback parameters.
Tests/KeystoneTests/Tests/Features/Dashboard/BlogDashboardServiceTests.swift	Test cleanup for unused snapshot parameter.
Tests/KeystoneTests/Tests/Features/Blog/BloggingRemindersSchedulerTests.swift	Test cleanup for unused notification mock parameters.
Modules/Sources/WordPressUI/Views/AdaptiveTabBarController.swift	Replaces unused trait-change callback parameters.
Modules/Sources/WordPressShared/Utility/String+Helpers.swift	Replaces unused match flags/stop parameters.
Modules/Sources/WordPressShared/Utility/Debouncer.swift	Replaces unused timer parameter.
Modules/Sources/WordPressKit/PostServiceRemoteREST.swift	Replaces unused HTTP response parameter.
Modules/Sources/WordPressKit/DashboardServiceRemote.swift	Replaces unused dictionary-merging parameter.
Modules/Sources/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift	UI-test cleanup for unused XCTContext activity parameters.
Modules/Sources/UITestsFoundation/Screens/Editor/AztecEditorScreen.swift	UI-test cleanup for unused XCTContext activity parameters.
Modules/Sources/UITestsFoundation/Globals.swift	UI-test cleanup for unused XCTContext activity parameter.
Modules/Sources/Support/UI/Support Conversations/SupportConversationListView.swift	Replaces unused `TimelineView` context parameter.
Modules/Sources/Support/UI/Support Conversations/AttachmentListView.swift	Replaces unused gesture transaction parameter.
Modules/Sources/Support/UI/OverlayProgressView.swift	Replaces unused `onChange` oldValue parameters.
Modules/Sources/Support/UI/Bot Conversations/CompositionView.swift	Replaces unused `onChange`/preview closure parameters.
Modules/Sources/Support/UI/Application Logs/ActivityLogDetailView.swift	Replaces unused state `onChange` oldValue parameter.
Modules/Sources/ShareExtensionCore/Data/SharedCoreDataStack.swift	Replaces unused persistent-store description parameter.
Modules/Sources/JetpackStats/Views/TopList/TopListItemsView.swift	Replaces unused enumerated index parameter.
Modules/Sources/JetpackStats/Views/Heatmap/WeeklyTrendsView.swift	Replaces unused week index parameter.
Modules/Sources/JetpackStats/Views/Customization/TopListCardCustomizationView.swift	Replaces unused `onChange` oldValue parameter.
Modules/Sources/JetpackStats/Services/Data/TopListData.swift	Replaces unused enumerated index parameters.
Modules/Sources/JetpackStats/Screens/UTMMetricStatsView.swift	Replaces unused `onChange` oldValue parameter.
Modules/Sources/JetpackStats/Screens/StatsMainView.swift	Replaces unused `onChange` oldValue parameter.
Modules/Sources/JetpackStats/Screens/AuthorStatsView.swift	Replaces unused `onChange` oldValue parameter.
Modules/Sources/JetpackStats/Cards/RealtimeTopListCard.swift	Replaces unused `onChange` oldValue parameter.
Modules/Sources/AsyncImageKit/Views/CachedAsyncImage.swift	Preview cleanup for unused image parameter.
.swiftlint.yml	Enables the `unused_closure_parameter` lint rule.

Comments suppressed due to low confidence (2)

WordPress/Classes/Utility/Notifications/PushNotificationsManager.swift:402

NotificationSyncMediator.sync reports both "no updates" and real failures as newData == false. By discarding the error here we always return .noData, so background sync failures are reported to iOS as successful no-op fetches instead of .failed.
WordPress/WordPressShareExtension/Sources/Services/ShareExtractor.swift:270
results is being mutated from each loadItem completion without any synchronization. Because multiple item providers are loaded asynchronously, these callbacks can race with each other, which can lead to lost items or undefined behavior while appending to the shared array.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mokagio · 2026-05-04T04:07:19Z

+        service.authenticate(token: token) { _ in
            self.parentCoordinator.track(.qrLoginAuthenticated)
            self.state = .done
            self.view.renderCompletion()


@copilot open a new PR to address this

mokagio · 2026-05-04T04:06:50Z

    func cancelStaticNotification(completion: @escaping (Bool) -> Void = { _ in }) {
-        userNotificationCenter.getPendingNotificationRequests { requests in
+        userNotificationCenter.getPendingNotificationRequests { _ in
            completion(true)


@copilot open a new PR to address this.

wpmobilebot · 2026-05-04T02:59:36Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`32087`
	Version	`PR #25517`
	Bundle ID	`org.wordpress.alpha`
	Commit	`5007012`
	Installation URL	76848a91adjeg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-05-04T02:59:42Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`32087`
	Version	`PR #25517`
	Bundle ID	`com.jetpack.alpha`
	Commit	`5007012`
	Installation URL	6snhm2ekd0ibg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copilot · 2026-05-04T04:06:59Z

@mokagio I've opened a new pull request, #25519, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-05-04T04:07:28Z

@mokagio I've opened a new pull request, #25520, to work on those changes. Once the pull request is ready, I'll request review from you.

mokagio self-assigned this May 4, 2026

Copilot AI review requested due to automatic review settings May 4, 2026 02:47

mokagio requested a review from a team as a code owner May 4, 2026 02:47

mokagio added the [Type] Tooling label May 4, 2026

mokagio added this to the 26.9 milestone May 4, 2026

Copilot started reviewing on behalf of mokagio May 4, 2026 02:48 View session

Copilot AI reviewed May 4, 2026

View reviewed changes

Copilot AI mentioned this pull request May 4, 2026

Fix cancelStaticNotification never actually cancelling the notification #25519

Draft

Copilot AI mentioned this pull request May 4, 2026

Fix QR Login: treat authenticate success(false) as rejection, not completion #25520

Draft

crazytonyli approved these changes May 5, 2026

View reviewed changes

mokagio added this pull request to the merge queue May 5, 2026

Merged via the queue into trunk with commit 622d767 May 5, 2026
30 checks passed

mokagio deleted the mokagio/swiftlint-unused-closure-parameter branch May 5, 2026 05:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable SwiftLint rule: unused_closure_parameter#25517

Enable SwiftLint rule: unused_closure_parameter#25517
mokagio merged 1 commit intotrunkfrom
mokagio/swiftlint-unused-closure-parameter

mokagio commented May 4, 2026

Uh oh!

dangermattic commented May 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

mokagio May 4, 2026

Uh oh!

mokagio May 4, 2026

Uh oh!

wpmobilebot commented May 4, 2026

Uh oh!

wpmobilebot commented May 4, 2026

Uh oh!

Copilot AI commented May 4, 2026

Uh oh!

Copilot AI commented May 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mokagio commented May 4, 2026

What

Stats

Testing

Uh oh!

dangermattic commented May 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

mokagio May 4, 2026

Choose a reason for hiding this comment

Uh oh!

mokagio May 4, 2026

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented May 4, 2026

Uh oh!

wpmobilebot commented May 4, 2026

Uh oh!

Copilot AI commented May 4, 2026

Uh oh!

Copilot AI commented May 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants