Fix QR Login: treat authenticate success(false) as rejection, not completion

[Copilot]

QRLoginServiceRemote.authenticate calls its success closure with false when the server responds but rejects the authentication (i.e., authenticated == false in the API response). The coordinator was ignoring this value and always transitioning to the .done state, incorrectly firing qrLoginAuthenticated and showing the completion UI on a rejected login.

Changes

• QRLoginVerifyCoordinator: Replace { _ in with { authenticated in } and guard on the value — false now transitions to .error, calls view.showAuthenticationFailedError(), and tracks qrLoginVerifyCodeFailed:

service.authenticate(token: token) { authenticated in
    guard authenticated else {
        self.state = .error
        self.view.showAuthenticationFailedError()
        self.parentCoordinator.track(.qrLoginVerifyCodeFailed, properties: ["error": "authentication_failed"])
        return
    }
    self.parentCoordinator.track(.qrLoginAuthenticated)
    self.state = .done
    self.view.renderCompletion()
} failure: { _ in ...

• QRLoginVerifyCoordinatorTests: Add .authenticationRejected mock expectation (calls success(false)) and a corresponding test testConfirmFromWaitingForUserVerificationAndAuthenticationRejected asserting the coordinator reaches .error, shows the auth-failed UI, and records the failure track.

[dangermattic]

	1 Message
📖	This PR is still a Draft: some checks will be skipped.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	32092
	Version	PR #25520
	Bundle ID	org.wordpress.alpha
	Commit	d845891
	Installation URL	2scpsgfj3p5e0

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	32092
	Version	PR #25520
	Bundle ID	com.jetpack.alpha
	Commit	d845891
	Installation URL	2jamnaj81n78o

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.