Fix cancelStaticNotification never actually cancelling the notification#25519
Draft
Fix cancelStaticNotification never actually cancelling the notification#25519
cancelStaticNotification never actually cancelling the notification#25519Conversation
Adds `unused_closure_parameter` to `.swiftlint.yml`'s `only_rules` and applies SwiftLint's autocorrection across the codebase. 340 violations were autofixed across 167 files; no manual fixes or `swiftlint:disable` comments were needed. Part of the Orchard SwiftLint rollout campaign. --- Generated with the help of Claude Code, https://claude.com/claude-code Co-Authored-By: Claude Code Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
…tification Agent-Logs-Url: https://github.com/wordpress-mobile/WordPress-iOS/sessions/0116e23e-0bd7-4c57-828c-3cbd1a1fcf31 Co-authored-by: mokagio <1218433+mokagio@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on enabling SwiftLint rule: unused_closure_parameter
Fix May 4, 2026
cancelStaticNotification never actually cancelling the notification
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 32091 | |
| Version | PR #25519 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 5d6738c | |
| Installation URL | 67ghjugs5h1p0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 32091 | |
| Version | PR #25519 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 5d6738c | |
| Installation URL | 0u04laarfii80 |
Base automatically changed from
mokagio/swiftlint-unused-closure-parameter
to
trunk
May 5, 2026 05:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


cancelStaticNotificationwas callinggetPendingNotificationRequestsbut discarding the result and never removing anything — the static weekly-roundup notification remained scheduled regardless.Change
Replace the no-op async fetch with a direct call to
removePendingNotificationRequests(withIdentifiers:):removePendingNotificationRequestsis synchronous, so the async closure is no longer needed.