warpui_core: TUI element library (text, column, container, child_view, event_handler)#12634
Draft
zachbai wants to merge 1 commit into
Draft
warpui_core: TUI element library (text, column, container, child_view, event_handler)#12634zachbai wants to merge 1 commit into
zachbai wants to merge 1 commit into
Conversation
Draft
3 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
zachbai
changed the base branch from
zb/tui-backend/03a-tui-seam
to
graphite-base/12634
zachbai
force-pushed
the
graphite-base/12634
branch
from
e30ebf4 to
f85df3c
Compare
zachbai
force-pushed
the
zb/tui-backend/03b-tui-elements
branch
from
a096d97 to
d2989fd
Compare
zachbai
changed the base branch from
graphite-base/12634
to
zb/tui-backend/03a-tui-seam
zachbai
changed the base branch from
zb/tui-backend/03a-tui-seam
to
graphite-base/12634
zachbai
force-pushed
the
zb/tui-backend/03b-tui-elements
branch
from
d2989fd to
33719f7
Compare
zachbai
force-pushed
the
graphite-base/12634
branch
from
f85df3c to
f02f2af
Compare
zachbai
changed the base branch from
graphite-base/12634
to
zb/tui-backend/03a-tui-seam
zachbai
changed the base branch from
zb/tui-backend/03a-tui-seam
to
graphite-base/12634
zachbai
force-pushed
the
graphite-base/12634
branch
from
f02f2af to
73c3649
Compare
zachbai
force-pushed
the
zb/tui-backend/03b-tui-elements
branch
from
33719f7 to
dbe7255
Compare
zachbai
changed the base branch from
graphite-base/12634
to
zb/tui-backend/03a-tui-seam
zachbai
force-pushed
the
zb/tui-backend/03a-tui-seam
branch
from
73c3649 to
c459ffb
Compare
zachbai
force-pushed
the
zb/tui-backend/03b-tui-elements
branch
from
dbe7255 to
7402b63
Compare
zachbai
changed the base branch from
zb/tui-backend/03a-tui-seam
to
graphite-base/12634
zachbai
force-pushed
the
graphite-base/12634
branch
from
c459ffb to
878719b
Compare
zachbai
force-pushed
the
zb/tui-backend/03b-tui-elements
branch
from
7402b63 to
2b8f634
Compare
zachbai
changed the base branch from
graphite-base/12634
to
zb/tui-backend/03a-tui-seam
zachbai
changed the base branch from
zb/tui-backend/03a-tui-seam
to
graphite-base/12634
zachbai
force-pushed
the
graphite-base/12634
branch
from
878719b to
b0ddbff
Compare
zachbai
force-pushed
the
zb/tui-backend/03b-tui-elements
branch
from
2b8f634 to
6f914f0
Compare
zachbai
changed the base branch from
graphite-base/12634
to
zb/tui-backend/03a-tui-seam
2 tasks
…, event_handler) Adds the concrete TuiElement implementors the TUI views compose: TuiText, TuiColumn, TuiContainer, TuiChildView, and TuiEventHandler (each with its own tests), and wires them into elements/tui/mod.rs. TuiChildView consumes the seam (render_tui_view + TuiEventContext::set_origin_view) added in the prior slice. Co-Authored-By: Oz <oz-agent@warp.dev>
zachbai
force-pushed
the
zb/tui-backend/03a-tui-seam
branch
from
b0ddbff to
4d98812
Compare
zachbai
force-pushed
the
zb/tui-backend/03b-tui-elements
branch
from
6f914f0 to
8f0d783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the concrete TUI element library on top of the
TuiElementtrait from #12633. Entirely behind thetuifeature — withtuioff this PR is inert (new files only, not compiled).Elements added, each with unit tests:
text,column,container,child_view,event_handler. These are the immediate-mode TUI analogues of the corresponding GUI elements — enough to build a real TUI view tree, which the presenter consumes in #12601.Reviewing: 12 new files under
elements/tui/, purely additive (1 deletion). No existing code path changes.Stack
#12413 → #12633 → #12634 (this) → #12601
Testing
cargo check -p warpui_core -p warp -p warpuiclean in both default and--features tui.--features tui).Agent Mode
CHANGELOG-NONE