warpui_core: in-core TUI seam + element trait and primitives behind the additive tui feature#12633
Draft
zachbai wants to merge 1 commit into
Draft
warpui_core: in-core TUI seam + element trait and primitives behind the additive tui feature#12633zachbai wants to merge 1 commit into
zachbai wants to merge 1 commit into
Conversation
This was referenced Jun 15, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 15, 2026
zachbai
changed the base branch from
zb/tui-backend/02-tui-view-layer
to
graphite-base/12633
zachbai
force-pushed
the
zb/tui-backend/03a-tui-seam
branch
from
e30ebf4 to
f85df3c
Compare
zachbai
force-pushed
the
graphite-base/12633
branch
from
7eb80a2 to
cb839d6
Compare
zachbai
changed the base branch from
graphite-base/12633
to
zb/tui-backend/02-tui-view-layer
…he additive tui feature Adds the shared-registry seam for a TuiView (StoredView::Tui in window.rs, TuiView/AnyTuiView, the AppContext add_tui_* / render_tui_view helpers, and the ViewContext add_tui_view hooks), the TuiElement trait + TuiEmpty + TuiPresentationContext, and the primitive submodules (geometry, buffer, event). Relaxes the shared view bounds (View -> Entity/'static), splits the unbounded ViewHandle accessors, and hoists the shared invalidation helper so a second view trait can flow through the existing paths. The tui cargo feature and its crossterm/unicode-* optional deps relocate here from the foundation. Runtime-drained event.rs methods/fields and TuiPresentationContext::new carry a scoped #[allow(dead_code)] (removed in the runtime slice). Co-Authored-By: Oz <oz-agent@warp.dev>
zachbai
changed the base branch from
zb/tui-backend/02-tui-view-layer
to
graphite-base/12633
zachbai
force-pushed
the
zb/tui-backend/03a-tui-seam
branch
from
f85df3c to
f02f2af
Compare
zachbai
force-pushed
the
graphite-base/12633
branch
from
cb839d6 to
68de666
Compare
zachbai
changed the base branch from
graphite-base/12633
to
zb/tui-backend/02-tui-view-layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked Issue
ready-to-specorready-to-implement.Testing
./script/runScreenshots / Videos
Agent Mode