warpui_core: backend-neutral core with an additive tui feature#12413
Draft
zachbai wants to merge 1 commit into
Draft
warpui_core: backend-neutral core with an additive tui feature#12413zachbai wants to merge 1 commit into
zachbai wants to merge 1 commit into
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 9, 2026
zachbai
force-pushed
the
zb/tui-backend/02-tui-view-layer
branch
2 times, most recently
from
dcb823a to
55a94a6
Compare
vorporeal
reviewed
Jun 10, 2026
vorporeal
left a comment
vorporeal
left a comment
Contributor
There was a problem hiding this comment.
code structure suggestion (agent can probably clean this up pretty easily):
might be nice to have a core/backend folder that contains gui and tui subfolders - we then can have parallel gui/view and tui/view hierarchies.
so something like:
crates/warpui_core/src/core/backend.rscrates/warpui_core/src/core/backend/gui.rscrates/warpui_core/src/core/backend/gui/view/context.rs
etc.
vorporeal
reviewed
Jun 10, 2026
Contributor
There was a problem hiding this comment.
should crates/warpui_core/src/elements really be "GUI elements", with the entire warpui_core::elements module (maybe warpui_core::gui_elements or warpui_core::elements::gui) being conditioned on not-tui?
zachbai
force-pushed
the
zb/tui-backend/02-tui-view-layer
branch
8 times, most recently
from
037ea72 to
60492af
Compare
zachbai
changed the base branch from
zb/tui-backend/01-core-backend-param
to
graphite-base/12413
zachbai
force-pushed
the
zb/tui-backend/02-tui-view-layer
branch
from
60492af to
0a1c519
Compare
zachbai
force-pushed
the
graphite-base/12413
branch
from
afea471 to
d098332
Compare
4 tasks
zachbai
force-pushed
the
zb/tui-backend/02-tui-view-layer
branch
from
0a1c519 to
7eb80a2
Compare
zachbai
changed the title
Collapses the former 01 (Backend-trait parameterization, since deleted) and 02 (neutral core + view unification + module structure) into one foundation: the GUI backend is compiled and aliased unconditionally, the tui feature is purely additive, and there is no Backend type parameter. Co-Authored-By: Oz <oz-agent@warp.dev>
zachbai
force-pushed
the
zb/tui-backend/02-tui-view-layer
branch
from
7eb80a2 to
cb839d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linked Issue
ready-to-specorready-to-implement.Testing
./script/runScreenshots / Videos
Agent Mode