Merged
Conversation
Owner
|
Hello Martin, Please give me a day or two to think about this issue, unfortunately I don't have much time on my hands right now but I will look into it. As your pull request seems to fix things by docs alone I will merge this at home later. Thank you :) |
Contributor
Author
Hi Valentin, No problem. Let me know if there is something I can do to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I realised that the fix I submitted previously was actually not fixing anything. This time I've made some more testing to make sure it works. This is the
.devcontainer.jsonused for my tests after making a local copy of the feature source code:{ "name": "Python", "image": "mcr.microsoft.com/devcontainers/python:1-3.13-bookworm", "features": { "ghcr.io/meaningful-ooo/devcontainer-features/fish:latest": {}, "./uv": { "shellautocompletion": true } }, "overrideFeatureInstallOrder": [ "ghcr.io/meaningful-ooo/devcontainer-features/fish", "./uv" ] }I added some debug traces with
echotoinstall.shand discovered that:uvfeature may be installed beforefish, and then the auto completionconfig.fishcheck fails.config.fishdoes not exist even whenfishshell has been installed beforeuv. However, the$HOME/.config/fishfolder does exist.The
mkdir -pcommand is probably not necessary. During debugging thecompletionsfolder already existed, but I thought it would be a good "just in case".The completions are saved into its own file, the fish documentation suggests that it helps to keep things tidy.
An alternative way to address the generation of the auto completion, would be to generate the completions for all the shells, and put them in a system wide location. In the case of fish, this could be
/etc/fish/completions. Maybe other shells have a similar way to keep them.As a side note, for debugging the builds of my
.devcontainer.jsonI used the following commands (fish shell syntax):I'm quite new to the development of devcontainer's features and templates. If you have comments or suggestions about how to do things, the feedback is welcome :-)