You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After our previous conversation in #8 , I thought that would be nice to install all the completions globally. In that way, the user does not have to keep in mind the order of the features.
I have tested this with bash, zsh and fish. As I could not find a devcontainer feature for elvish, I left the code for that shell untouched.
Hi,
thank you for the pull request. I think this might be a solution but we have to see, for now I think it's good the autocompletion isn't enabled by default because I had to change the base image to get the tests working again. Depending on the underlying image it will probably still race with fish.
I also removed elvish completely, I tried to make it work somehow but don't see a way to get this done within a reasonable timeframe right now.
I had to change the base image to get the tests working again. Depending on the underlying image it will probably still race with fish.
Could it be that the path where the completions are going to be saved does not exist yet? We could include a mkdir -p <path> to create the destination before saving the completions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
After our previous conversation in #8 , I thought that would be nice to install all the completions globally. In that way, the user does not have to keep in mind the order of the features.
I have tested this with
bash,zshandfish. As I could not find a devcontainer feature for elvish, I left the code for that shell untouched.Let me know what you think.