Skip to content

Fix uv completions on fish #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
va-h merged 4 commits into from
Feb 5, 2025
Merged

Fix uv completions on fish #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0213123
fix: Check for the existance of the fish config folder. Generate comp…
mmartinortiz Feb 5, 2025
498813e
docs: Override features installation order
mmartinortiz Feb 5, 2025
264c1a1
docs: fixed a typo
va-h Feb 5, 2025
3f57ef7
chore: bumped patch version of uv feature
va-h Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion src/uv/NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,23 @@
## uv Repository

* [astral-sh/uv](https://github.com/astral-sh/uv)
* [astral-sh/uv](https://github.com/astral-sh/uv)

## Fix Autocompletion with feature Shells

> [!IMPORTANT]
> When installing a shell via another feature, make sure to override the installation order to ensure the generated autocompletion writes to existing files.

### Autocompletion for Fish Shell

```json
"features": {
"ghcr.io/meaningful-ooo/devcontainer-features/fish:latest": {},
"ghcr.io/va-h/devcontainers-features/uv:latest": {
"shellautocompletion": true
}
},
"overrideFeatureInstallOrder": [
"ghcr.io/meaningful-ooo/devcontainer-features/fish",
"ghcr.io/va-h/devcontainers-features/uv:latest"
]
```
4 changes: 2 additions & 2 deletions src/uv/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "uv",
"version": "1.1.2",
"version": "1.1.3",
"name": "uv",
"documentationURL": "http://github.com/va-h/devcontainers-features/tree/main/src/uv",
"description": "An extremely fast Python package and project manager, written in Rust.",
Expand All @@ -19,4 +19,4 @@
"type": "boolean"
}
}
}
}
5 changes: 3 additions & 2 deletions src/uv/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,9 @@ enable_autocompletion() {
if [ -f "$_REMOTE_USER_HOME/.zshrc" ]; then
echo "eval \"\$(${command} zsh)\"" >> $_REMOTE_USER_HOME/.zshrc
fi
if [ -f "$_REMOTE_USER_HOME/.config/fish/config.fish" ]; then
echo "${command} fish" >> $_REMOTE_USER_HOME/.config/fish/config.fish
if [ -d "$_REMOTE_USER_HOME/.config/fish" ]; then
mkdir -p $_REMOTE_USER_HOME/.config/fish/completions
${command} fish >> $_REMOTE_USER_HOME/.config/fish/completions/uv.fish
fi
if [ -f "$_REMOTE_USER_HOME/.elvish/rc.elv" ]; then
echo "eval (${command} elvish | slurp)" >> $_REMOTE_USER_HOME/.elvish/rc.elv
Expand Down