add ACLE random number generation intrinsics#2050
Open
folkertdev wants to merge 3 commits intorust-lang:mainfrom
Open
add ACLE random number generation intrinsics#2050folkertdev wants to merge 3 commits intorust-lang:mainfrom
folkertdev wants to merge 3 commits intorust-lang:mainfrom
Conversation
Contributor
Author
|
cc @adamgemmell to check that this makes sense. Internally the feature appears to be called |
Collaborator
|
r? @sayantn rustbot has assigned @sayantn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
sayantn
reviewed
Mar 12, 2026
crates/core_arch/src/aarch64/rand.rs
Outdated
|
|
||
| unsafe extern "unadjusted" { | ||
| #[cfg_attr( | ||
| any(target_arch = "aarch64", target_arch = "arm64ec"), |
Contributor
There was a problem hiding this comment.
I don't think you need these cfg_attrs here, as this is the aarch64 module.
Contributor
Author
There was a problem hiding this comment.
right. I based this off of mte.rs so I've removed the cfg_attrs there too.
folkertdev
force-pushed
the
aarch64-rand
branch
2 times, most recently
from
5db9698 to
0cf01e1
Compare
folkertdev
force-pushed
the
aarch64-rand
branch
from
0cf01e1 to
709ece1
Compare
sayantn
reviewed
Mar 13, 2026
| /// SAFETY: See `__arm_mte_create_random_tag`. | ||
| #[inline] | ||
| #[target_feature(enable = "mte")] | ||
| #[cfg_attr(test, assert_instr(addg))] |
Contributor
There was a problem hiding this comment.
Suggested change
| #[cfg_attr(test, assert_instr(addg))] | |
| #[cfg_attr(test, assert_instr(addg, OFFSET=0))] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: rust-lang/rust#153514