[perf-only] rustdoc: Unconditionally enable --generate-link-to-definition and lazily typeck nested bodies with a cache#156355
Conversation
…d bodies with cache
|
@bors try parent=fb0a5a5a9c892b351f34263d6d84da9dde72871a @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[perf-only] rustdoc: Unconditionally enable `--generate-link-to-definition` and lazily typeck nested bodies with a cache
| //FIXME: Allegedly, we might actually typeck code here that's cfg'ed out | ||
| // which could lead to errors getting reported which would be wild. | ||
| // Re-audit this! Do we have any tests demonstrating this? |
There was a problem hiding this comment.
(it doesn't affect cfg'ed out code, it just means we're type-checking bodies which we usually don't do; it means we can't document std)
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (69577e4): comparison URL. Overall result: ❌ regressions - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 5.4%, secondary 4.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 20.6%, secondary 15.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 497.93s -> 498.488s (0.11%) |
Compare with: #156349, #156348.