Skip to content

[perf-only] rustdoc: Unconditionally enable --generate-link-to-definition and eagerly typeck nested bodies#156349

Draft
fmease wants to merge 1 commit intorust-lang:mainfrom
fmease:rustdoc-ltd-eager-typck
Draft

[perf-only] rustdoc: Unconditionally enable --generate-link-to-definition and eagerly typeck nested bodies#156349
fmease wants to merge 1 commit intorust-lang:mainfrom
fmease:rustdoc-ltd-eager-typck

Conversation

@fmease
Copy link
Copy Markdown
Member

@fmease fmease commented May 9, 2026

Compare with: #156355, #156348.

@fmease fmease added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. rla-silenced Silences rust-log-analyzer postings to the PR it's added on. labels May 9, 2026
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels May 9, 2026
@fmease
Copy link
Copy Markdown
Member Author

fmease commented May 9, 2026

@bors try parent=fb0a5a5a9c892b351f34263d6d84da9dde72871a @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 9, 2026
[perf-only] rustdoc: generate-link-to-definition: Eagerly typeck nested bodies
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 9, 2026
Comment on lines +247 to +248
// FIXME: Allegedly, we might actually typeck code here that's cfg'ed out
// which could lead to errors getting reported which would be wild.
Copy link
Copy Markdown
Member Author

@fmease fmease May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, not cfg'ed out, I misunderstood. We're obv now typeck'ing bodies which we're usually not doing in rustdoc which means we can't document std anymore.

View changes since the review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 9, 2026

☀️ Try build successful (CI)
Build commit: ea5e0a8 (ea5e0a8bc1ea61d698cc6ce2eb2169148cee0c18, parent: fb0a5a5a9c892b351f34263d6d84da9dde72871a)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (ea5e0a8): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
21.2% [3.7%, 50.7%] 19
Regressions ❌
(secondary)
16.0% [0.3%, 126.7%] 22
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 21.2% [3.7%, 50.7%] 19

Max RSS (memory usage)

Results (primary 5.9%, secondary 4.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
6.4% [1.0%, 17.4%] 17
Regressions ❌
(secondary)
4.8% [2.0%, 10.8%] 10
Improvements ✅
(primary)
-1.9% [-1.9%, -1.9%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 5.9% [-1.9%, 17.4%] 18

Cycles

Results (primary 27.0%, secondary 16.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
27.0% [3.9%, 63.1%] 19
Regressions ❌
(secondary)
16.0% [2.2%, 112.7%] 21
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 27.0% [3.9%, 63.1%] 19

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 497.93s -> 499.015s (0.22%)
Artifact size: 397.14 MiB -> 397.09 MiB (-0.01%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels May 9, 2026
@fmease fmease changed the title [perf-only] rustdoc: generate-link-to-definition: Eagerly typeck nested bodies [perf-only] rustdoc: Unconditionally enable --generate-link-to-definition and eagerly typeck nested bodies May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants