[perf-only] rustdoc: Unconditionally enable --generate-link-to-definition and eagerly typeck nested bodies#156349
[perf-only] rustdoc: Unconditionally enable --generate-link-to-definition and eagerly typeck nested bodies#156349fmease wants to merge 1 commit intorust-lang:mainfrom
--generate-link-to-definition and eagerly typeck nested bodies#156349Conversation
|
@bors try parent=fb0a5a5a9c892b351f34263d6d84da9dde72871a @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[perf-only] rustdoc: generate-link-to-definition: Eagerly typeck nested bodies
| // FIXME: Allegedly, we might actually typeck code here that's cfg'ed out | ||
| // which could lead to errors getting reported which would be wild. |
There was a problem hiding this comment.
Lol, not cfg'ed out, I misunderstood. We're obv now typeck'ing bodies which we're usually not doing in rustdoc which means we can't document std anymore.
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (ea5e0a8): comparison URL. Overall result: ❌ regressions - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 5.9%, secondary 4.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 27.0%, secondary 16.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 497.93s -> 499.015s (0.22%) |
--generate-link-to-definition and eagerly typeck nested bodies
Compare with: #156355, #156348.