Skip to content

[perf-only] rustdoc: Unconditionally enable --generate-link-to-definition#156348

Draft
fmease wants to merge 1 commit intorust-lang:mainfrom
fmease:rustdoc-ltd-always
Draft

[perf-only] rustdoc: Unconditionally enable --generate-link-to-definition#156348
fmease wants to merge 1 commit intorust-lang:mainfrom
fmease:rustdoc-ltd-always

Conversation

@fmease
Copy link
Copy Markdown
Member

@fmease fmease commented May 9, 2026

Compare with #156355, #156349.

@fmease fmease added S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. rla-silenced Silences rust-log-analyzer postings to the PR it's added on. labels May 9, 2026
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels May 9, 2026
@fmease
Copy link
Copy Markdown
Member Author

fmease commented May 9, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label May 9, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 9, 2026
[perf-only] rustdoc: Unconditionally enable `--generate-link-to-definition`
@fmease fmease removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 9, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 9, 2026

☀️ Try build successful (CI)
Build commit: 68c2bff (68c2bff6cb08a87e59246064a6a9f37098e22c3f, parent: fb0a5a5a9c892b351f34263d6d84da9dde72871a)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (68c2bff): comparison URL.

Overall result: ❌ regressions - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
16.5% [2.1%, 44.1%] 19
Regressions ❌
(secondary)
13.2% [0.3%, 120.7%] 19
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 16.5% [2.1%, 44.1%] 19

Max RSS (memory usage)

Results (primary 5.0%, secondary 4.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
5.5% [1.3%, 14.9%] 16
Regressions ❌
(secondary)
4.6% [1.4%, 8.8%] 6
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 5.0% [-2.1%, 14.9%] 17

Cycles

Results (primary 21.0%, secondary 17.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
21.0% [2.4%, 56.4%] 19
Regressions ❌
(secondary)
17.7% [2.2%, 101.4%] 15
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 21.0% [2.4%, 56.4%] 19

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 497.93s -> 497.245s (-0.14%)
Artifact size: 397.14 MiB -> 397.10 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regression Performance regression. rla-silenced Silences rust-log-analyzer postings to the PR it's added on. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants