Fix charge.succeeded webhook crash on removed Charge#subscription - #2114
Merged
Conversation
Stripe gem 19.x pins an API version that dropped Charge#subscription, so every charge.succeeded webhook raised NoMethodError before recording the payment. Subscription (membership) charges carry an invoice and are handled via the membership/invoice flow, so detect and skip them by invoice presence instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jmilljr24
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 one-line webhook guard swap + spec update, contained
What is the goal of this PR and why is this important?
charge.succeededwebhooks were crashing withNoMethodError: undefined method 'subscription' for #<Stripe::Charge>(Honeybadger), so noExternalProcessorPaymentrecords were being created.stripegem 19.x pins an API version that droppedCharge#subscription.How did you approach the change?
invoiceand are recorded via the membership/invoice flow, so skip them byinvoice.present?instead of the removedsubscription.Stripe::Charge(nosubscriptionmethod), which reproduced the crash before the fix.Anything else to add?
invoice.present?skips any invoice-backed charge; for this app that's the intended set (membership dues are the only Stripe-invoice flow).