Skip to content

Skip subscription-invoice test while #2115 temp fix is active - #2121

Merged
maebeale merged 1 commit into
mainfrom
maebeale/fix-stripe-charge-skip-test
Aug 9, 2026
Merged

Skip subscription-invoice test while #2115 temp fix is active#2121
maebeale merged 1 commit into
mainfrom
maebeale/fix-stripe-charge-skip-test

Conversation

@maebeale

@maebeale maebeale commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

🤖 suggested review level: 3 Read 📖 one-line test change reconciling the spec with #2115's temp fix

What is the goal of this PR and why is this important?

How did you approach the change?

  • Skip that one example (skip with a note tying it to temp fix #2115) so the suite is green while the guard is off, and it reactivates the moment the guard is uncommented.
  • Deliberately did not re-enable the guard — disabling it was the intent of temp fix #2115.

Anything else to add?

  • Trade-off: subscription-skip behavior is untested until the guard is restored. Alternative was to flip the test to assert the current temp reality (invoice charge creates an EPP); chose skip so restoring the guard needs no test rewrite.

#2115 commented out the invoice-based subscription-skip guard but left the
spec asserting the skip, leaving the suite red. Skip that example (with a
note tying it to #2115) so it reactivates when the guard is restored.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 9, 2026 12:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@maebeale
maebeale marked this pull request as ready for review August 9, 2026 12:08
@maebeale
maebeale requested a review from jmilljr24 August 9, 2026 12:08
@maebeale
maebeale merged commit a25dd3e into main Aug 9, 2026
3 checks passed
@maebeale
maebeale deleted the maebeale/fix-stripe-charge-skip-test branch August 9, 2026 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants