Skip subscription-invoice test while #2115 temp fix is active - #2121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 one-line test change reconciling the spec with #2115's temp fix
What is the goal of this PR and why is this important?
main: Fix charge.succeeded webhook crash on removed Charge#subscription #2114 added the invoice-based subscription-skip guard + a spec asserting the skip; temp fix #2115 ("temp fix") commented the guard out but left the spec, so the skip it expects no longer happens.How did you approach the change?
skipwith a note tying it to temp fix #2115) so the suite is green while the guard is off, and it reactivates the moment the guard is uncommented.Anything else to add?