Skip to content

Fix charge.succeeded webhook crash on removed Charge#subscription #2114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmilljr24 merged 1 commit into from
Aug 9, 2026
Merged

Fix charge.succeeded webhook crash on removed Charge#subscription #2114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/webhooks/stripe_charge_succeeded_processor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ class StripeChargeSucceededProcessor
def call(event)
stripe_charge = event.data.object
return unless stripe_charge.paid
return if stripe_charge.subscription.present?
# Subscription (membership) charges carry an invoice and are recorded via the
# membership/invoice flow — skip them here. Newer Stripe API versions dropped
# Charge#subscription, so detect them by the presence of an invoice.
return if stripe_charge.invoice.present?

return if Payment.exists?(stripe_charge_id: stripe_charge.id)

Expand Down
6 changes: 3 additions & 3 deletions spec/webhooks/stripe_charge_succeeded_processor_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
billing_details: nil,
receipt_email: nil,
customer: nil,
subscription: nil,
invoice: nil,
to_hash: { "id" => stripe_charge_id, "amount" => 30_00 }
)
end
Expand Down Expand Up @@ -47,8 +47,8 @@
expect { processor.call(event) }.not_to change(ExternalProcessorPayment, :count)
end

it "does nothing when the charge belongs to a subscription" do
allow(stripe_charge).to receive(:subscription).and_return("sub_membership")
it "does nothing when the charge belongs to a subscription (has an invoice)" do
allow(stripe_charge).to receive(:invoice).and_return("in_membership")

expect { processor.call(event) }.not_to change(ExternalProcessorPayment, :count)
end
Expand Down