fix(rivetkit): surface native sqlite kv errors to callers

[NathanFlurry]

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[NathanFlurry]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• chore(engine): publish engine bases in ci #4649 : 2 dependent PRs (#4650 , #4652 )
• chore: lockfile lefthook #4647
• fix(rivetkit): surface native sqlite kv errors to callers #4645 👈 (View in Graphite)
• fix(rivetkit): prevent sleep races during disconnect and db work #4644
• fix(rivetkit): isolate engine envoys and propagate startup failures #4643
• test(rivetkit): remove wasm sqlite-only fixtures and coverage #4642
• chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring #4641
• chore(rivetkit): remove wasm sqlite runtime #4614
• fix(sqlite-native): restore native startup kv preload #4639
• fix(sqlite-native): delete metadata before chunk range #4638
• fix(sqlite-native): keep truncate cache coherent #4637
• fix(sqlite-vfs): use delete range for truncate cleanup #4636
• fix(sqlite-native): restore kv error hook #4635
• perf(sqlite-native): avoid cloning cached read chunks #4634
• perf(sqlite-native): gate kv operation labels #4633
• perf(sqlite-native): reuse read cache for partial writes #4632
• perf(sqlite-native): remove delete file existence probe #4631
• fix(sqlite-native): gate native read cache behind env var #4630
• fix(pegboard): isolate runner config dc lookup failures #4625 : 1 other dependent PR (#4626 )
• docs(pegboard): note runner config upsert split write risk #4624
• fix(pegboard): unpack global runner config keys correctly #4623
• fix(pegboard-gateway): enforce tunnel message state #4622
• fix(pegboard-runner): clear terminal tunnel routes #4621
• fix(pegboard): skip protocol version keys in runner pool backfill #4620
• fix(pegboard): create missing normal runner configs #4619
• fix(epoxy): reuse cached optimistic value #4618
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: fix(rivetkit): surface native sqlite kv errors to callers

The overall approach is solid - enriching I/O-level errors with KV context while leaving application-level SQLite errors (schema, constraint, etc.) untouched is the right design.

Potential issue: exec error path variable assignment

In the wrapped exec method, result is declared with let before the try block and used after it. TypeScript control flow should handle this since enrichNativeDatabaseError returns never, but under strict mode some TS versions still flag the variable as potentially uninitialized. Worth verifying this compiles cleanly. The run and query wrappers avoid this issue because they do not use a result variable afterward.

Concern: Mutating the caught error object

The code does error.message = ... which mutates the error in-place. Consider creating a new Error with the enriched message and copying error.stack to preserve the original stack trace. Minor concern since these errors are unlikely to be shared, but it is safer practice.

Missing test coverage for exec and query

The two tests only exercise run(). The same enrichment logic is wired into exec() and query(), but there are no tests verifying those paths. Adding at least one test per method would prevent regressions.

Minor: takeLastKvError placement in the interface

The method was inserted between run and close. Consider grouping it at the bottom of the interface as a diagnostic extension for readability.

Minor: Regex coverage

The regex covers i/o error and unable to open database file but SQLite can also emit disk full and SQLITE_IOERR-style messages for I/O failures. A brief comment explaining the intentional narrowness would help future maintainers.

Overall this is a clean, well-scoped diagnostic improvement. Main actionable items: expand test coverage to exec and query, and consider the error mutation pattern.