Skip to content

chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring#4641

Open
NathanFlurry wants to merge 1 commit intochore/remove-wasm-sqlite-native-onlyfrom
chore/remove-sqlite-vfs-packages
Open

chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring#4641
NathanFlurry wants to merge 1 commit intochore/remove-wasm-sqlite-native-onlyfrom
chore/remove-sqlite-vfs-packages

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 13, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude bot commented Apr 13, 2026

PR Review: chore(sqlite-vfs): remove wasm sqlite packages and workspace wiring

Note: This is a draft PR targeting chore/remove-wasm-sqlite-native-only (part of a stacked PR workflow).

Summary

Clean removal of the @rivetkit/sqlite-vfs WASM SQLite package (~8,600 lines), its test suite, internal specs, and all workspace wiring. The intent is clear and the scope is well-contained.


Issues

🔴 @rivetkit/engine-api-full changed to a PR preview URL in pnpm-lock.yaml

The diff shows @rivetkit/engine-api-full override changed to a pkg.pr.new ephemeral preview URL. These URLs are tied to a specific CI run and expire -- this should not be merged as-is. The override needs to point to a stable workspace reference or pinned version.

🟡 WASM/native VFS parity (CLAUDE.md requirement)

CLAUDE.md states the native Rust VFS and the WASM TypeScript VFS must match 1:1. This PR removes the WASM TypeScript VFS. Confirm the native side is being removed or replaced in the parent branch (chore/remove-wasm-sqlite-native-only), or update/remove the parity note in CLAUDE.md if the constraint no longer applies after the full stack lands.

🟡 examples/sandbox/pnpm-lock.yaml deleted

The sandbox lock file is removed but the package still exists in the workspace. Confirm pnpm resolves sandbox dependencies correctly from the root lock file -- deleting a self-contained lock file without verifying root-level resolution can cause silent install failures.


Observations

Ladle Dockerfile removes platform-specific packages not in this diff

Lines removing sqlite-vfs-linux-arm64 and sqlite-vfs-linux-x64 COPY commands reference packages not in this diff. Are they removed in the parent branch, or were they already absent from the repo?

DYNAMIC_ACTOR_SQLITE_PROXY_SPEC.md deleted

This spec describes the replacement architecture (host-side SQLite bridge via sqliteExec/sqliteBatch RPC). If that replacement has not been implemented yet, deleting the spec loses design context. Worth confirming the deletion is intentional.

Cargo.lock churn in rivetkit-rust/Cargo.lock

405 additions / 420 deletions of Rust dependency versions look like incidental version bumps unrelated to the WASM SQLite removal. Worth confirming they are intentional and not accidentally carried from another branch.


Verdict

The cleanup is correct and well-scoped. The blocking item is the pkg.pr.new URL in pnpm-lock.yaml which must be resolved before merging. The WASM/native parity concern and lock file deletion are worth a quick confirmation before the stack lands. Also worth adding a one-line description to the PR body for future git archaeology.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant