test(rivetkit): remove wasm sqlite-only fixtures and coverage#4642
test(rivetkit): remove wasm sqlite-only fixtures and coverage#4642NathanFlurry wants to merge 1 commit intochore/remove-sqlite-vfs-packagesfrom
Conversation
|
PR Review: test(rivetkit): remove wasm sqlite-only fixtures and coverage This PR cleanly removes ~1,200 lines of WASM SQLite test infrastructure as part of the shift to a native-only SQLite runtime. The intent is clear and the bulk of the deletions are straightforward. A few items worth addressing before merging. Issues 1. Unnecessary try/catch in bench-sqlite.ts The try/catch wrapping a plain console.log serves no purpose since console.log does not throw. This should just be a bare console.log call. 2. Delta-documenting comments in bench-sqlite.ts CLAUDE.md says to avoid documenting what was there before. The comment "the old sqlite-native channel inspection path is gone" adds no value for a developer who never saw the old code. Either drop the comment or replace it with a forward-looking statement, e.g. Native database metrics are exposed via @rivetkit/rivetkit-native. 3. limits.mdx: clarify whether the SQLite preload limit still applies The removed row documented Max SQLite preload size: 768 KiB and a configurable option options.preloadMaxSqliteBytes. If native SQLite no longer uses KV preloading at all (data stays on local disk), this deletion is correct. If the engine still preloads SQLite data to the runner at startup, the limit table should retain or replace this row with the native equivalent. 4. utils.ts formatting-only change The only change in utils.ts is a multi-line reformat of a function call with no semantic effect. Looks like an incidental editor change worth reverting to keep the diff focused. Minor
What is done well
|
0bc1a8e to
b7e88da
Compare
ada1fe0 to
dbb2ed4
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: