Skip to content

test(rivetkit): remove wasm sqlite-only fixtures and coverage#4642

Draft
NathanFlurry wants to merge 1 commit intochore/remove-sqlite-vfs-packagesfrom
test/remove-wasm-sqlite-fixtures
Draft

test(rivetkit): remove wasm sqlite-only fixtures and coverage#4642
NathanFlurry wants to merge 1 commit intochore/remove-sqlite-vfs-packagesfrom
test/remove-wasm-sqlite-fixtures

Conversation

@NathanFlurry
Copy link
Copy Markdown
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Copy Markdown
Member Author

NathanFlurry commented Apr 13, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link
Copy Markdown

claude bot commented Apr 13, 2026

PR Review: test(rivetkit): remove wasm sqlite-only fixtures and coverage

This PR cleanly removes ~1,200 lines of WASM SQLite test infrastructure as part of the shift to a native-only SQLite runtime. The intent is clear and the bulk of the deletions are straightforward. A few items worth addressing before merging.

Issues

1. Unnecessary try/catch in bench-sqlite.ts

The try/catch wrapping a plain console.log serves no purpose since console.log does not throw. This should just be a bare console.log call.

2. Delta-documenting comments in bench-sqlite.ts

CLAUDE.md says to avoid documenting what was there before. The comment "the old sqlite-native channel inspection path is gone" adds no value for a developer who never saw the old code. Either drop the comment or replace it with a forward-looking statement, e.g. Native database metrics are exposed via @rivetkit/rivetkit-native.

3. limits.mdx: clarify whether the SQLite preload limit still applies

The removed row documented Max SQLite preload size: 768 KiB and a configurable option options.preloadMaxSqliteBytes. If native SQLite no longer uses KV preloading at all (data stays on local disk), this deletion is correct. If the engine still preloads SQLite data to the runner at startup, the limit table should retain or replace this row with the native equivalent.

4. utils.ts formatting-only change

The only change in utils.ts is a multi-line reformat of a function call with no semantic effect. Looks like an incidental editor change worth reverting to keep the diff focused.

Minor

  • ACTOR_KV_STRUCTURE.md: Removing the sqlite (8)/ namespace section is correct. Consider adding a one-line pointer to docs-internal/engine/NATIVE_SQLITE_DATA_CHANNEL.md so readers who land here know where the current SQLite data layout is documented.
  • Test coverage: The removed actor-sleep-db.ts tested a "poisoned KV produces disk IO error on commit" scenario that reproduced a real production failure mode. If there is no equivalent test for how the native path surfaces IO errors to the actor runtime, worth tracking as a follow-up.

What is done well

  • CLAUDE.md and rivetkit-typescript/CLAUDE.md updates are concise and correct: single bullet points, no paragraphs, forward-looking.
  • All WASM-specific fixture actors, test files, and registry entries are consistently removed with no orphaned references left behind.
  • The mod.ts cleanup correctly removes both the KV channel config setup and teardown alongside the removed test suites.

@NathanFlurry NathanFlurry force-pushed the chore/remove-sqlite-vfs-packages branch from 0bc1a8e to b7e88da Compare April 13, 2026 21:07
@NathanFlurry NathanFlurry force-pushed the test/remove-wasm-sqlite-fixtures branch from ada1fe0 to dbb2ed4 Compare April 13, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant