Skip to content

[ET-VK][qlinear] Add bias support to q4gsw and dq8ca_q4gsw quantized linear ops#18061

Open
SS-JIA wants to merge 4 commits intogh/SS-JIA/478/basefrom
gh/SS-JIA/478/head
Open

[ET-VK][qlinear] Add bias support to q4gsw and dq8ca_q4gsw quantized linear ops#18061
SS-JIA wants to merge 4 commits intogh/SS-JIA/478/basefrom
gh/SS-JIA/478/head

Conversation

@SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Mar 10, 2026

…linear ops

Wire bias through the q4gsw and dq8ca_q4gsw quantized linear operators.
Add add_bias_to_out_tile() helper in the output tile computation header and call
it from all three shader variants (tiled, coop, dq8ca_tiled). Remove the bias
guard in the pattern matcher to allow biased linear layers.

Differential Revision: [D95970172](https://our.internmc.facebook.com/intern/diff/D95970172/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18061

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Pending, 1 Unrelated Failure

As of commit eb4c833 with merge base 8a285b7 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

ssjia added 3 commits March 11, 2026 09:52
… quantized linear ops"

Wire bias through the q4gsw and dq8ca_q4gsw quantized linear operators.
Add add_bias_to_out_tile() helper in the output tile computation header and call
it from all three shader variants (tiled, coop, dq8ca_tiled). Remove the bias
guard in the pattern matcher to allow biased linear layers.

Differential Revision: [D95970172](https://our.internmc.facebook.com/intern/diff/D95970172/)

[ghstack-poisoned]
… quantized linear ops"

Wire bias through the q4gsw and dq8ca_q4gsw quantized linear operators.
Add add_bias_to_out_tile() helper in the output tile computation header and call
it from all three shader variants (tiled, coop, dq8ca_tiled). Remove the bias
guard in the pattern matcher to allow biased linear layers.

Differential Revision: [D95970172](https://our.internmc.facebook.com/intern/diff/D95970172/)

[ghstack-poisoned]
… quantized linear ops"

Wire bias through the q4gsw and dq8ca_q4gsw quantized linear operators.
Add add_bias_to_out_tile() helper in the output tile computation header and call
it from all three shader variants (tiled, coop, dq8ca_tiled). Remove the bias
guard in the pattern matcher to allow biased linear layers.

Differential Revision: [D95970172](https://our.internmc.facebook.com/intern/diff/D95970172/)

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant