[ET-VK] Add ANY_STORAGE support to embedding#18057
Open
SS-JIA wants to merge 4 commits intogh/SS-JIA/474/basefrom
Open
[ET-VK] Add ANY_STORAGE support to embedding#18057SS-JIA wants to merge 4 commits intogh/SS-JIA/474/basefrom
SS-JIA wants to merge 4 commits intogh/SS-JIA/474/basefrom
Conversation
Register embedding as ANY_STORAGE. The buffer and texture shaders already exist and support both storage types. Differential Revision: [D95970161](https://our.internmc.facebook.com/intern/diff/D95970161/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18057
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 1 Unrelated FailureAs of commit 1c93fe3 with merge base 8a285b7 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This was referenced Mar 10, 2026
added 3 commits
March 11, 2026 09:52
Register embedding as ANY_STORAGE. The buffer and texture shaders already exist and support both storage types. Differential Revision: [D95970161](https://our.internmc.facebook.com/intern/diff/D95970161/) [ghstack-poisoned]
Register embedding as ANY_STORAGE. The buffer and texture shaders already exist and support both storage types. Differential Revision: [D95970161](https://our.internmc.facebook.com/intern/diff/D95970161/) [ghstack-poisoned]
Register embedding as ANY_STORAGE. The buffer and texture shaders already exist and support both storage types. Differential Revision: [D95970161](https://our.internmc.facebook.com/intern/diff/D95970161/) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Register embedding as ANY_STORAGE. The buffer and texture shaders
already exist and support both storage types.
Differential Revision: D95970161