Skip to content

[ET-VK] Add ANY_STORAGE support to embedding#18057

Open
SS-JIA wants to merge 4 commits intogh/SS-JIA/474/basefrom
gh/SS-JIA/474/head
Open

[ET-VK] Add ANY_STORAGE support to embedding#18057
SS-JIA wants to merge 4 commits intogh/SS-JIA/474/basefrom
gh/SS-JIA/474/head

Conversation

Register embedding as ANY_STORAGE. The buffer and texture shaders
already exist and support both storage types.

Differential Revision: [D95970161](https://our.internmc.facebook.com/intern/diff/D95970161/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 10, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18057

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 1 Unrelated Failure

As of commit 1c93fe3 with merge base 8a285b7 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

ssjia added 3 commits March 11, 2026 09:52
Register embedding as ANY_STORAGE. The buffer and texture shaders
already exist and support both storage types.

Differential Revision: [D95970161](https://our.internmc.facebook.com/intern/diff/D95970161/)

[ghstack-poisoned]
Register embedding as ANY_STORAGE. The buffer and texture shaders
already exist and support both storage types.

Differential Revision: [D95970161](https://our.internmc.facebook.com/intern/diff/D95970161/)

[ghstack-poisoned]
Register embedding as ANY_STORAGE. The buffer and texture shaders
already exist and support both storage types.

Differential Revision: [D95970161](https://our.internmc.facebook.com/intern/diff/D95970161/)

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant