[ET-VK] Add ANY_STORAGE support to native_layer_norm#18055
Open
SS-JIA wants to merge 3 commits intogh/SS-JIA/472/basefrom
Open
[ET-VK] Add ANY_STORAGE support to native_layer_norm#18055SS-JIA wants to merge 3 commits intogh/SS-JIA/472/basefrom
SS-JIA wants to merge 3 commits intogh/SS-JIA/472/basefrom
Conversation
Add a buffer shader variant for native_layer_norm using workgroup-based reduction with shared memory. Each workgroup handles one output row, with NUM_WORKERS (64) threads cooperatively reducing across the row width for mean and variance computation. Rename the existing texture shader to native_layer_norm_texture.glsl/.yaml and register the op as ANY_STORAGE so buffer-storage inputs are now accepted. Differential Revision: [D95970158](https://our.internmc.facebook.com/intern/diff/D95970158/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18055
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit a9def01 with merge base 365d89a ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
meta-cla
bot
added
the
CLA Signed
This was referenced Mar 10, 2026
added 2 commits
March 11, 2026 09:52
Add a buffer shader variant for native_layer_norm using workgroup-based reduction with shared memory. Each workgroup handles one output row, with NUM_WORKERS (64) threads cooperatively reducing across the row width for mean and variance computation. Rename the existing texture shader to native_layer_norm_texture.glsl/.yaml and register the op as ANY_STORAGE so buffer-storage inputs are now accepted. Differential Revision: [D95970158](https://our.internmc.facebook.com/intern/diff/D95970158/) [ghstack-poisoned]
Add a buffer shader variant for native_layer_norm using workgroup-based reduction with shared memory. Each workgroup handles one output row, with NUM_WORKERS (64) threads cooperatively reducing across the row width for mean and variance computation. Rename the existing texture shader to native_layer_norm_texture.glsl/.yaml and register the op as ANY_STORAGE so buffer-storage inputs are now accepted. Differential Revision: [D95970158](https://our.internmc.facebook.com/intern/diff/D95970158/) [ghstack-poisoned]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add a buffer shader variant for native_layer_norm using workgroup-based
reduction with shared memory. Each workgroup handles one output row, with
NUM_WORKERS (64) threads cooperatively reducing across the row width for
mean and variance computation. Rename the existing texture shader to
native_layer_norm_texture.glsl/.yaml and register the op as ANY_STORAGE
so buffer-storage inputs are now accepted.
Differential Revision: D95970158