[10/n] [sled-agent] make RackNetworkConfig ports a non-empty UplinkPorts newtype#10651
Merged
sunshowers merged 5 commits intoJul 1, 2026
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Jun 29, 2026
sunshowers
changed the base branch from
sunshowers/spr/main.10n-sled-agent-make-racknetworkconfig-ports-a-non-empty-uplinkports-newtype
to
main
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/10n-sled-agent-make-racknetworkconfig-ports-a-non-empty-uplinkports-newtype
branch
sunshowers
added a commit
that referenced
this pull request
Jul 1, 2026
Realized while working on this stack that we were still using untyped UUIDs for the rack UUID. Since we're going to be working on multirack soon, let's convert the UUID type over now. Depends on: * #10651 * earlier commits in the stack
sunshowers
added a commit
that referenced
this pull request
Jul 2, 2026
Similar to the rack ID migration done in #10651, also migrate the BGP announce set IDs over. The address lot block ID appears to (a) always be set to the same thing as the BGP announce set ID, and (b) be unused -- I'm not touching it here but it would be good to understand its purpose. Depends on: * #10651 * #10652 * earlier commits in the stack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In prior commits in the stack, we made it so that transient DB errors don't result in a partially-generated config. This change encodes one specific form of that (non-empty ports) into the type system.
Making bootstore deserialization fallible is an improvement in this case, because it turns a panic into a loop.
Also include a change to make the rack ID in
StartSledAgentRequesta typedRackUuid. This isn't directly related but is spiritually similar and I'm touching this code anyway.Depends on: