[12/n] [meta] migrate BGP announce set IDs to typed UUIDs#10653
Open
Conversation
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Jun 29, 2026
| address_lot_block_id: bas.identity.id, | ||
| announce_set_id: to_db_typed_uuid(db_as.id()), | ||
| // XXX: address_lot_block_id seems unused -- get rid of | ||
| // it? |
Contributor
There was a problem hiding this comment.
Can we file an issue for this for the networking folks to weigh in?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to the rack ID migration done in #10651, also migrate the BGP announce set IDs over.
The address lot block ID appears to (a) always be set to the same thing as the BGP announce set ID, and (b) be unused -- I'm not touching it here but it would be good to understand its purpose.
Depends on: