[11/n] [meta] migrate rack IDs to typed UUIDs#10652
Open
sunshowers wants to merge 3 commits into
Open
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Contributor
|
Looks like |
jgallagher
approved these changes
Jun 29, 2026
jgallagher
left a comment
jgallagher
left a comment
Contributor
There was a problem hiding this comment.
Looks like bootstrap::server::tests::test_persistent_sled_agent_request_schema failed.
I believe this test is to catch any accidental breakage for the on-disk-serialized StartSledAgentRequests. In this case the schema change is wire-compatible, so I think it's fine to just EXPECTORATE=overwrite it?
| let addr = sled.address(); | ||
| Self { | ||
| rack_id, | ||
| rack_id: rack_id.into_untyped_uuid(), |
Contributor
There was a problem hiding this comment.
I assume we only support generic Uuid in oximeter timeseries - is there any reason to push support for typed UUIDs down to that? (I can't think of one, if the only benefit is to drop these conversions when constructing something for oximeter to consume)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Realized while working on this stack that we were still using untyped UUIDs for the rack UUID. Since we're going to be working on multirack soon, let's convert the UUID type over now.
Depends on: