Skip to content

HYPERFLEET-1524 - fix: enable gomodTidy in Renovate config - #254

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1524-renovate-gomod-tidy
Aug 24, 2026
Merged

HYPERFLEET-1524 - fix: enable gomodTidy in Renovate config#254
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1524-renovate-gomod-tidy

Conversation

@rafabene

Copy link
Copy Markdown
Member

Summary

  • Adds postUpdateOptions: ["gomodTidy"] to renovate.json so Renovate runs go mod tidy after updating dependencies.
  • Fixes CI failures in "go module minor/patch updates" PRs (e.g. Update go module minor/patch updates #253), where go.sum was left missing entries for transitive test-only packages (github.com/stretchr/testify/assert/require) after a grouped dependency bump, breaking the golangci-lint typecheck step.

Test plan

  • Confirm the next Renovate "go module minor/patch updates" PR has a consistent go.sum and passes lint CI

Jira: https://redhat.atlassian.net/browse/HYPERFLEET-1524

@openshift-ci
openshift-ci Bot requested review from aredenba-rh and kuudori August 24, 2026 13:01
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3851e388-05f6-44ab-81e8-d580d56c21e2

📥 Commits

Reviewing files that changed from the base of the PR and between 1f87fe2 and e2b5ffa.

📒 Files selected for processing (1)
  • renovate.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual) → reviewed against open PR #351 HYPERFLEET-1524-renovate-gomod-tidy instead of the default branch
  • openshift-hyperfleet/hyperfleet-sentinel (manual)
  • openshift-hyperfleet/hyperfleet-adapter (manual) → reviewed against open PR #285 HYPERFLEET-1524-renovate-gomod-tidy instead of the default branch
  • openshift-hyperfleet/hyperfleet-broker (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Improved automated dependency updates by running Go module cleanup after updates.

Walkthrough

Renovate now runs gomodTidy after dependency updates through the postUpdateOptions configuration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e2b5f

This localized Renovate configuration change enables dependency updates to run go mod tidy; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: kuudori, aredenba-rh

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed The PR changes only renovate.json. No Go or logger files changed, and the non-test/non-example scan found no sensitive token, password, credential, or secret in log fields or messages.
No Hardcoded Secrets ✅ Passed The diff adds only the literal Renovate option "gomodTidy"; no secret, credential URL, private key, or long base64 string was introduced. No CWE/CVE applies.
No Weak Cryptography ✅ Passed HEAD^..HEAD changes only renovate.json, adding gomodTidy; the introduced patch contains no banned cryptographic primitive, comparison, or custom cryptography.
No Injection Vectors ✅ Passed The pull request changes only renovate.json, adding gomodTidy; no SQL, command execution, template.HTML, or yaml.Unmarshal injection pattern was introduced.
No Privileged Containers ✅ Passed The PR changes only renovate.json by adding gomodTidy; no Kubernetes/OpenShift manifest, Helm template, or Dockerfile changes introduce a listed privilege condition.
No Pii Or Sensitive Data In Logs ✅ Passed The commit changes only renovate.json by adding gomodTidy; no logging statements or PII, session IDs, request bodies, or credentialed hostnames were introduced.
Title check ✅ Passed The title clearly identifies the issue and the primary change to enable gomodTidy in the Renovate configuration.
Description check ✅ Passed The description directly explains the Renovate configuration change, the CI failure it addresses, and the planned verification.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1524-renovate-gomod-tidy
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch HYPERFLEET-1524-renovate-gomod-tidy

Comment @coderabbitai help to get the list of available commands.

@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 0 — risk/low

Signal Detail Points
PR size 3 lines +0
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

@kuudori

kuudori commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuudori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit bea3d5e into main Aug 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants