Skip to content

HYPERFLEET-1524 - fix: enable gomodTidy in Renovate config - #351

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1524-renovate-gomod-tidy
Aug 24, 2026
Merged

HYPERFLEET-1524 - fix: enable gomodTidy in Renovate config#351
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1524-renovate-gomod-tidy

Conversation

@rafabene

Copy link
Copy Markdown
Member

Summary

  • Adds postUpdateOptions: ["gomodTidy"] to renovate.json so Renovate runs go mod tidy after updating dependencies.
  • Fixes CI failures in "go module minor/patch updates" PRs (e.g. Update go module minor/patch updates - autoclosed #350), where go.sum was left missing entries for transitive test-only packages (github.com/stretchr/testify/assert/require) after a grouped dependency bump, breaking the golangci-lint typecheck step.

Test plan

  • Confirm the next Renovate "go module minor/patch updates" PR has a consistent go.sum and passes lint CI

Jira: https://redhat.atlassian.net/browse/HYPERFLEET-1524

@openshift-ci
openshift-ci Bot requested review from ldornele and rh-amarin August 24, 2026 13:01
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 54fe0518-be33-4d1e-8a8d-a901c0fb9f1b

📥 Commits

Reviewing files that changed from the base of the PR and between 50b9e36 and 57a0277.

📒 Files selected for processing (1)
  • renovate.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual)
  • openshift-hyperfleet/hyperfleet-sentinel (manual) → reviewed against open PR #254 HYPERFLEET-1524-renovate-gomod-tidy instead of the default branch
  • openshift-hyperfleet/hyperfleet-adapter (manual) → reviewed against open PR #285 HYPERFLEET-1524-renovate-gomod-tidy instead of the default branch
  • openshift-hyperfleet/hyperfleet-broker (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Improved automated maintenance for Go module updates.
    • Module metadata is now automatically tidied after dependency updates, helping keep project configuration consistent and reducing manual cleanup.

Walkthrough

The Renovate configuration adds postUpdateOptions with gomodTidy. Renovate will run Go module tidying after Go module updates.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 57a02

This localized configuration change enables dependency updates to run go mod tidy, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: ldornele, rh-amarin

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed The only changed file is renovate.json, adding gomodTidy; no slog, log, logr, zap, or fmt.Print* statement contains a secret field or interpolation.
No Hardcoded Secrets ✅ Passed The commit adds only the literal Renovate option "gomodTidy"; JSON validation found no secret assignment, embedded credentials, or base64 string over 32 characters.
No Weak Cryptography ✅ Passed The commit changes only renovate.json, adding postUpdateOptions: ["gomodTidy"]. No banned primitive, custom cryptography, or secret comparison was introduced.
No Injection Vectors ✅ Passed The PR changes only renovate.json by adding literal gomodTidy; no CWE-78, CWE-79, CWE-89, or CWE-502 injection pattern is introduced.
No Privileged Containers ✅ Passed The PR changes only renovate.json by adding gomodTidy. No Kubernetes manifest or Dockerfile changed; the existing Dockerfile USER root line is unchanged.
No Pii Or Sensitive Data In Logs ✅ Passed The commit changes only renovate.json to enable gomodTidy; it introduces no slog, logr, zap, log, or fmt.Print* logging statements.
Title check ✅ Passed The title clearly identifies the Renovate configuration fix that enables gomodTidy.
Description check ✅ Passed The description directly explains the gomodTidy change and its intended CI fix for dependency update pull requests.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1524-renovate-gomod-tidy
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch HYPERFLEET-1524-renovate-gomod-tidy

Comment @coderabbitai help to get the list of available commands.

@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 0 — risk/low

Signal Detail Points
PR size 3 lines +0
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

@kuudori

kuudori commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuudori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit eb249c0 into main Aug 24, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants