Skip to content

HYPERFLEET-1524 - fix: enable gomodTidy in Renovate config - #285

Merged
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1524-renovate-gomod-tidy
Aug 24, 2026
Merged

HYPERFLEET-1524 - fix: enable gomodTidy in Renovate config#285
openshift-merge-bot[bot] merged 1 commit into
mainfrom
HYPERFLEET-1524-renovate-gomod-tidy

Conversation

@rafabene

Copy link
Copy Markdown
Member

Summary

  • Adds postUpdateOptions: ["gomodTidy"] to renovate.json so Renovate runs go mod tidy after updating dependencies.
  • Fixes CI failures in "go module minor/patch updates" PRs (e.g. Update go module minor/patch updates #283), where go.sum was left missing entries for transitive test-only packages (github.com/stretchr/testify/assert/require) after a grouped dependency bump, breaking the golangci-lint typecheck step.

Test plan

  • Confirm the next Renovate "go module minor/patch updates" PR has a consistent go.sum and passes lint CI

Jira: https://redhat.atlassian.net/browse/HYPERFLEET-1524

@openshift-ci
openshift-ci Bot requested review from Mischulee and mliptak0 August 24, 2026 13:00
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fb316e04-fe69-4fdb-a470-ef13d991462f

📥 Commits

Reviewing files that changed from the base of the PR and between c6dabc7 and 0323fe1.

📒 Files selected for processing (1)
  • renovate.json
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual) → reviewed against branch HYPERFLEET-1524-renovate-gomod-tidy instead of the default branch
  • openshift-hyperfleet/hyperfleet-sentinel (manual) → reviewed against open PR #254 HYPERFLEET-1524-renovate-gomod-tidy instead of the default branch
  • openshift-hyperfleet/hyperfleet-adapter (manual)
  • openshift-hyperfleet/hyperfleet-broker (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Go module files are now automatically tidied after dependency updates.

Walkthrough

The Renovate configuration adds postUpdateOptions with gomodTidy. Renovate will run Go module tidy operations after dependency updates.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0323f

This is a localized Renovate configuration change to run go mod tidy after dependency updates; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: mischulee, mliptak0

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed The PR changes only renovate.json; the added gomodTidy configuration contains no slog, log, logr, zap, or fmt.Print* statement or sensitive field.
No Hardcoded Secrets ✅ Passed The diff adds only the Renovate option gomodTidy; valid JSON and scans found no hardcoded secret, credential URL, or long base64 string. No CWE/CVE applies.
No Weak Cryptography ✅ Passed The PR changes only renovate.json and adds valid gomodTidy configuration; the diff contains no banned cryptography, custom crypto, or secret comparisons.
No Injection Vectors ✅ Passed The diff changes only renovate.json by adding the literal postUpdateOptions value "gomodTidy"; no CWE-89, CWE-78, CWE-79, or CWE-502 injection pattern is introduced.
No Privileged Containers ✅ Passed The PR changes only renovate.json by adding gomodTidy. No Kubernetes/OpenShift manifest or Dockerfile privileged-container setting is introduced; the existing Dockerfile USER root is unchanged.
No Pii Or Sensitive Data In Logs ✅ Passed The diff only adds Renovate's gomodTidy option to renovate.json; it adds no logging statements or logged PII, request bodies, session IDs, or host credentials.
Title check ✅ Passed The title clearly identifies the Renovate configuration change and the enabled gomodTidy option.
Description check ✅ Passed The description directly explains the gomodTidy change, the affected CI failure, and the planned validation.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch HYPERFLEET-1524-renovate-gomod-tidy
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch HYPERFLEET-1524-renovate-gomod-tidy

Comment @coderabbitai help to get the list of available commands.

@hyperfleet-ci-bot

Copy link
Copy Markdown

Risk Score: 0 — risk/low

Signal Detail Points
PR size 3 lines +0
Sensitive paths none +0

Computed by hyperfleet-risk-scorer

@kuudori

kuudori commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kuudori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit e4935d2 into main Aug 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants