test: avoid flaky debugger restart waits

[inoway46]

Summary

• replace stepCommand('restart') with command('restart') in:
  • test/parallel/test-debugger-restart-message.js
  • test/parallel/test-debugger-run-after-quit-restart.js
• in test-debugger-restart-message, wait for Debugger attached. and prompt before asserting the listening message count
• in test-debugger-run-after-quit-restart, continue to assert behavior via waitForInitialBreak() and breakInfo

Context

test-macOS has shown intermittent timeouts while waiting for BREAK_MESSAGE in restart-related debugger tests.
In failing logs, reconnect succeeds (Debugger attached. is printed), but the expected break ... in line is not observed before timeout.

Hypothesis

The flake is likely caused by a timing race in CLI output ordering around restart/reconnect:

• stepCommand() requires BREAK_MESSAGE to appear
• under some timing conditions (seen on macOS unusual-path runs), attach/prompt output arrives, but break ... in output is delayed or missed by this wait pattern

This change does not claim to prove a single root cause. It may be related to timing behavior in test/common/debugger.js, but this PR only narrows these two tests to a less fragile synchronization path aligned with what each test is actually verifying.

Why this approach

• keep test intent intact
• reduce dependence on a brittle BREAK_MESSAGE wait specifically for restart
• minimize blast radius by changing only the affected tests

Testing

• out/Release/node test/parallel/test-debugger-restart-message.js (passes locally)
• out/Release/node test/parallel/test-debugger-run-after-quit-restart.js (passes locally)
• Additional local stress runs were executed from an unusual-character path on both this PR branch and main. (test: avoid flaky debugger restart waits #61773 (comment))
• CI passes on macOS

Refs: #61762

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (5babc8d) to head (e6adfbe).
⚠️ Report is 32 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61773      +/-   ##
==========================================
- Coverage   89.78%   89.77%   -0.01%     
==========================================
  Files         674      674              
  Lines      204957   204957              
  Branches    39391    39398       +7     
==========================================
- Hits       184011   184006       -5     
- Misses      13214    13221       +7     
+ Partials     7732     7730       -2     

see 33 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[inoway46]

Quick update: this flake reproduced again in Test macOS (run https://github.com/nodejs/node/actions/runs/22255995247), with the same timeout path in test-debugger-restart-message.js (stepCommand waiting for BREAK_MESSAGE after restart).
This PR is intended as a targeted mitigation for that exact failure.
Happy to split/follow up if you’d prefer a broader fix in test/common/debugger.js.

[inoway46]

Quick update on local verification (macOS 15.7.4, Apple M2 Pro).

I ran stress checks from an unusual-character path to match the CI scenario:

UNUSUAL="$HOME/dir with \$unusual\"chars?'åß∂ƒ©∆¬…\`"
mkdir -p "$UNUSUAL"
ln -sfn "$PWD" "$UNUSUAL/node"
cd "$UNUSUAL/node"

./tools/test.py -p actions -j1 --repeat 50 \
  parallel/test-debugger-restart-message \
  parallel/test-debugger-run-after-quit-restart

./tools/test.py -p actions -j4 --repeat 100 \
  parallel/test-debugger-restart-message \
  parallel/test-debugger-run-after-quit-restart

Results:

• This PR branch: no local failures in the runs above.
• main: no local failures in the same runs.

Since I could not reproduce this locally, I cannot claim high confidence that this change fixes the flake; however, if possible, running CI multiple times on this diff should help validate whether it reduces recurrence.

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71400/

[inoway46]

node-test-linux-alpine-latest-x64 failed during checkout (before running tests):
fatal: update_ref failed for ref 'HEAD': cannot lock ref 'HEAD': Unable to create '/home/iojs/build/workspace/node/.git/HEAD.lock': File exists.

Looks like a CI workspace issue unrelated to this PR.
Could someone re-run the failed job (or the workflow)? Thanks!

https://ci.nodejs.org/job/node-test-commit-linux/nodes=alpine-latest-x64/68594/console

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/71439/

[avivkeller]

Thank you! This flake has me going 🤪

[nodejs-github-bot]

Landed in 4f04a36