test: reduce waitForInitialBreak() flakiness in debugger tests#61937
Draft
inoway46 wants to merge 1 commit intonodejs:mainfrom
Draft
test: reduce waitForInitialBreak() flakiness in debugger tests#61937inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
497d1a4 to
67c068f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61937 +/- ##
==========================================
- Coverage 89.65% 89.65% -0.01%
==========================================
Files 676 676
Lines 206231 206240 +9
Branches 39505 39510 +5
==========================================
+ Hits 184898 184905 +7
Misses 13463 13463
- Partials 7870 7872 +2 🚀 New features to boost your workflow:
|
This comment was marked as resolved.
This comment was marked as resolved.
a7a76cf to
ead6d72
Compare
ead6d72 to
6e208f5
Compare
6e208f5 to
e75e571
Compare
e75e571 to
e605443
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes flakiness around
waitForInitialBreak()in debugger tests.waitForInitialBreak()can be flaky during startup because the CLI may already attach and printdebug>before the initialbreak ... inoutput arrives. In some CI runs, tests end up waiting on that break message while startup output is still racing.This change takes two approaches:
waitForInitialBreak()no longer use it.waitForInitialBreak()now wait fordebug>first. This synchronizes with the CLI becoming interactive and reduces the startup race before waiting for the initial break.CI failed logs on main branch (Nov 27, 2025 ~ Mar 8, 2026)
test-debugger-help.mjstest-debugger-break.jstest-debugger-preserve-breaks.jstest-debugger-backtrace.jstest-debugger-random-port-with-inspect-port.jstest-debugger-watch-validation.jstest-debugger-profile.jstest-debugger-object-type-remote-object.jstest-debugger-low-level.jstest-debugger-exec.jstest-debugger-set-context-line-number.mjstest-debugger-scripts.jstest-debugger-sb-before-load.jstest-debugger-exceptions.jstest-debugger-clear-breakpoints.jstest-debugger-auto-resume.mjsRefs: #61762