test: avoid flaky run wait in debugger restart test#62112
Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
Open
test: avoid flaky run wait in debugger restart test#62112inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46 wants to merge 1 commit intonodejs:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62112 +/- ##
=======================================
Coverage 89.64% 89.65%
=======================================
Files 676 676
Lines 206330 206330
Branches 39518 39517 -1
=======================================
+ Hits 184973 184977 +4
+ Misses 13480 13475 -5
- Partials 7877 7878 +1 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Mar 5, 2026
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #61773
test/parallel/test-debugger-run-after-quit-restart.jscan still flake on macOS unusual-path runs aroundrun.stepCommand('run')expects a break message immediately, butrunmay returnok/prompt before the break output.This change switches those calls to
command('run')and keepswaitForInitialBreak()for the actual break sync.failed CI logs:
Testing
./tools/test.py -p actions parallel/test-debugger-run-after-quit-restart./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restart./tools/test.py -p actions -j1 --repeat 50 parallel/test-debugger-run-after-quit-restart(unusual path)Refs: #61762