Report resolved backend for play benchmarks - #7173
Conversation
There was a problem hiding this comment.
Isaac Lab Review Bot
The four benchmark play adapters now pass their resolved env_cfg to capture.run_config_from_presets, aligning reported run.config.physics_backend with the backend actually used while retaining requested tokens in run.config.presets.
- Design and architecture: Backend identification remains centralized in
capture.run_config_from_presets; the rl_games, rsl_rl, sb3, and skrl adapters reuse their existing resolved environment configuration rather than duplicating backend-resolution logic. - API: The change uses the existing
env_cfgkeyword without altering the function signature, exports, or defaults. The intentional metadata behavior change forisaacsim_physxis documented in the isaaclab changelog fragment. - Implementation: All four play paths pass
env_cfgbefore constructing benchmark metadata, and the focused capture test verifies that anisaacsim_physxpreset with a resolved PhysX configuration reportsphysics_backendasphysx. The requested preset remains available throughcfg.presets; the only compatibility tradeoff is for metadata consumers that previously interpreted the requested preset name as the resolved backend.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Greptile SummaryThe PR makes all four benchmark play adapters derive run metadata from the resolved environment configuration, aligning play reporting with training, runtime, and startup behavior.
Confidence Score: 5/5The PR appears safe to merge, with the changed play adapters consistently using the resolved configuration already followed by sibling benchmark paths. The four adapters pass a native resolved environment configuration whose backend fields are finalized before metadata capture, and no changed-code-triggered failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
CLI[Play benchmark arguments] --> Resolve[Resolve task environment config]
Resolve --> Launch[Resolve and launch simulation backend]
Launch --> Capture[Build RunConfig from presets and env_cfg]
Capture --> Metadata[Report resolved physics backend]
Reviews (1): Last reviewed commit: "Report resolved backend for play benchma..." | Re-trigger Greptile |
Description
Fixed benchmark play adapters to pass the resolved environment configuration when building
RunConfig. This makesrun.config.physics_backendreport the backend that ran, matching training, runtime, and startup behavior.For
isaacsim_physx, play results now reportphysx; the requested preset remains inrun.config.presets.No additional dependencies are required.
Type of change
Screenshots
Not applicable.
Checklist
source/<pkg>/changelog.d/for every touched packageCONTRIBUTORS.md