Add video recording to play benchmarks - #7172
Conversation
Greptile SummaryThe PR adds opt-in video recording to all four RL play benchmark adapters and reports the effective recording directory in each play bundle.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The four adapters consistently enable cameras before launch, apply recorder settings before environment creation, preserve configured output directories, and report the directory actually used by the recorder. Important Files Changed
Sequence DiagramsequenceDiagram
participant Request as Benchmark play request
participant Parser as Backend argument parser
participant Config as Environment config
participant Sim as Simulation launcher
participant Env as Gym environment
participant Bundle as PlayBundle
Request->>Parser: --video and --video_length
Parser->>Parser: Enable cameras
Parser->>Config: Resolve task configuration
Config->>Config: Add visualizer before launch
Config->>Sim: Launch simulation
Sim->>Config: Apply recorder configuration
Config->>Env: Create environment with recorder
Env-->>Bundle: Effective recorder output directory
Reviews (1): Last reviewed commit: "Add video recording to play benchmarks" | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
Reviewed video recording integration across the RSL-RL, RL-Games, SKRL, and SB3 play benchmark adapters. The changes consistently use the existing shared lifecycle helpers and populate PlayBundle.video_path without altering the default no-video path.
- Design and architecture: All four adapters follow the same sequence: enable cameras during argument processing, inject pre-launch visualizer configuration, apply recorder settings after simulation launch but before environment creation, and expose the effective recorder directory. A minor residual coupling is that each adapter directly reads video_recorders[0], so multi-recorder behavior would require coordinated updates.
- API: The new --video and --video_length backend arguments are consistently exposed across all four adapters, use the repository’s CLI naming convention, and preserve the existing behavior when recording is not requested. The user-visible addition is represented by a source/isaaclab changelog fragment.
- Implementation: The parsing, launch ordering, recorder configuration, environment-creation path, and bundle construction were traced across each backend. Tests cover argument forwarding, camera enablement, visualizer setup, recorder configuration before environment creation, and preservation of a preconfigured output directory. No actionable implementation defect is established by the supplied patch.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Description
Adds video recording support to the RSL-RL, RL-Games, SKRL, and SB3 play benchmark adapters.
Each adapter now:
This preserves preconfigured recorder output directories and leaves no-video behavior unchanged. No dependencies or public APIs were added.
Type of change
Screenshots
Not applicable.
Validation
Checklist