Report checkpoint paths for RL-Games and SKRL benchmarks - #7171
Report checkpoint paths for RL-Games and SKRL benchmarks#7171AntoineRichard wants to merge 1 commit into
Conversation
Greptile SummaryThe PR populates RL-Games and SKRL training bundles with checkpoint paths by reusing the canonical checkpoint resolver.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or non-blocking defects identified. The resolver targets each completed run exactly, uses checkpoint layouts consistent with the two backends, and preserves the optional bundle field when no matching artifact exists. Important Files Changed
Reviews (1): Last reviewed commit: "Report training benchmark checkpoint pat..." | Re-trigger Greptile |
There was a problem hiding this comment.
Isaac Lab Review Bot
The change correctly populates RL-Games and SKRL training bundle checkpoint paths by reusing the existing checkpoint resolver, while retaining None when no checkpoint can be resolved.
- Design and architecture: The shared helper centralizes backend-specific checkpoint layouts and avoids duplicating filesystem search logic. Its placement in the training entrypoint creates an internal dependency from backend adapters to that module, but the patch shows no circular import, public stability requirement, or concrete maintenance failure requiring relocation before merge.
- API:
TrainingBundle.checkpoint_pathretains its optionalstr | Nonecontract. Missing directories and unmatched checkpoints remain non-fatal, and the user-visible behavior change is covered by the package changelog fragment. - Implementation: The RL-Games and SKRL adapters pass their established run log directories to the resolver. Exact run-directory matching avoids selecting sibling runs, backend patterns cover the documented checkpoint layouts, and tests cover matching filenames, absent checkpoints, and natural numeric ordering. Selection among different SKRL checkpoint forms continues to follow the canonical resolver’s ordering.
No blocking issues. No inline issue met the actionable-evidence threshold; the assessment above records the review feedback.
Automated review; human maintainers own approval decisions.
Description
RL-Games and SKRL training benchmark bundles now report the checkpoint produced by the completed run instead of leaving TrainingBundle.checkpoint_path unset.
This reuses the canonical get_checkpoint_path resolver rather than adding a second filesystem search mechanism. A small benchmark helper supplies the backend-specific layout and filename patterns:
The change intentionally leaves RSL-RL, SB3, video handling, and Odin tooling untouched.
Type of change
Testing
Checklist