Draft: New-Newton-API - #7145
Conversation
Greptile SummaryThis draft migrates Newton camera rendering from
Confidence Score: 4/5The default-light regression should be fixed before merging because the renderer silently ignores an enabled configuration and can leave scenes unlit. The new initialization path constructs the Vulkan render context but comments out the only operation that implements the enabled-by-default directional-light behavior. Files Needing Attention: source/isaaclab_newton/isaaclab_newton/renderers/newton_warp_renderer.py Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
Camera["Isaac Lab Camera"] --> Update["RenderData.update"]
Update --> Sensor["Newton SensorCamera"]
Camera --> Outputs["RenderData.set_outputs"]
Sensor --> Context["Vulkan RenderContext.render"]
Outputs --> Context
Context --> Buffers["Color / depth / segmentation buffers"]
Reviews (1): Last reviewed commit: "Update pyproject to point to vulkan rend..." | Re-trigger Greptile |
| # if self.cfg.create_default_light: | ||
| # self.render_context.create_default_light(enable_shadows=self.cfg.enable_shadows) |
There was a problem hiding this comment.
Default light creation is disabled
When a scene relies on the enabled-by-default create_default_light setting, initialization skips the only call that creates that directional light, causing color output to render unlit or dark instead of honoring the renderer configuration.
| # if self.cfg.create_default_light: | |
| # self.render_context.create_default_light(enable_shadows=self.cfg.enable_shadows) | |
| if self.cfg.create_default_light: | |
| self.render_context.create_default_light(enable_shadows=self.cfg.enable_shadows) |
Description
Important
Confirm the pull request base before submitting. Target
developfor allcontributions. The
release/3.0.0-beta2branch is a frozen stable landingsnapshot and is not used for ongoing maintenance.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there