Angehu/perf smoke integration - #7137
Draft
angehu-nv wants to merge 12 commits into
Draft
Conversation
Require every authoritative baseline to cover throughput and both memory metrics so missing data cannot silently pass. Reject non-finite inputs and drop the unsupported Newton and Isaac RTX camera combination.
Add total startup timing to the required performance metrics. Qualify FPS regressions with coherent iteration-time statistics and reject malformed or inconsistent benchmark data. Use provider-qualified runtime identities so kit-less Newton runs compare correctly.
Write benchmark JSON to container-local storage while Isaac Sim is running, then copy the completed result to the host artifact mount. This avoids the reproducible RTX finalization failure on the bind-mounted path without changing benchmark behavior.
Keep benchmark results in container-local storage and use host-side docker cp after the run. This removes the non-root bind-mount write that consistently fails for the RTX workload while preserving the normal container user.
Keep runtime benchmarks aligned with the established arithmetic FPS semantics by default while allowing callers to opt into effective aggregate throughput. Compare performance baselines using the matching per-step FPS statistics.
Keep the machine-readable JSON and workflow summary while removing unused JUnit and Markdown artifacts. Reduce duplicate significance fields and repetitive validation tests without changing gate semantics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Important
Confirm the pull request base before submitting. Target
developfor allcontributions. The
release/3.0.0-beta2branch is a frozen stable landingsnapshot and is not used for ongoing maintenance.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bumpextension.toml— CI handles that)CONTRIBUTORS.mdor my name already exists there