Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions source/isaaclab/changelog.d/peterd-mimic-installs-teleop.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Changed
^^^^^^^

* ``./isaaclab.sh -i mimic`` now also installs ``isaaclab_teleop`` as an editable
submodule, since :mod:`isaaclab_mimic` declares it as a required dependency.
2 changes: 1 addition & 1 deletion source/isaaclab/isaaclab/cli/commands/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ def _install_isaacsim() -> None:
# Optional submodules — only installed when explicitly requested or with 'all'.
# Maps the short CLI name to one or more source directory names under source/.
OPTIONAL_ISAACLAB_SUBMODULES: dict[str, tuple[str, ...]] = {
"mimic": ("isaaclab_mimic",),
"mimic": ("isaaclab_teleop", "isaaclab_mimic"),
"teleop": ("isaaclab_teleop",),
}

Expand Down
2 changes: 1 addition & 1 deletion source/isaaclab/test/cli/test_install_command_parsing.py
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def test_core_submodules_contains_expected_packages(self):

def test_optional_submodules_contains_expected_packages(self):
assert set(OPTIONAL_ISAACLAB_SUBMODULES.keys()) == {"mimic", "teleop"}
assert OPTIONAL_ISAACLAB_SUBMODULES["mimic"] == ("isaaclab_mimic",)
assert OPTIONAL_ISAACLAB_SUBMODULES["mimic"] == ("isaaclab_teleop", "isaaclab_mimic")
assert OPTIONAL_ISAACLAB_SUBMODULES["teleop"] == ("isaaclab_teleop",)

def test_valid_extra_features(self):
Expand Down
6 changes: 6 additions & 0 deletions source/isaaclab_mimic/changelog.d/isaaclab-teleop-dep.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Changed
^^^^^^^

* Declared ``isaaclab_teleop`` as a required extension of
``isaaclab_mimic`` in ``install.py``. ``./isaaclab.sh -i mimic``
now installs ``isaaclab_teleop`` alongside ``isaaclab_mimic``.
Loading