Updates PhysX GPU buffer dimensions for ARL navigation environment#5783
Updates PhysX GPU buffer dimensions for ARL navigation environment#5783kellyguo11 wants to merge 1 commit into
Conversation
Greptile SummaryThis PR bumps three PhysX GPU buffer parameters in the ARL Robot 1 navigation environment to resolve GPU buffer overflow errors that occur during large-scale simulation runs with 4096 environments.
Confidence Score: 5/5Safe to merge — the change is a targeted GPU buffer enlargement that directly addresses documented overflow errors, with no functional logic changes. All three parameter names are valid fields on the PhysxCfg class imported from isaaclab_physx.physics. The values are scaled-up powers of 2 consistent with how similar environments in the repo tune these buffers, and gpu_found_lost_aggregate_pairs_capacity (default 225) remains larger than the newly set gpu_found_lost_pairs_capacity (223), preserving the expected ordering. The changelog fragment is present and correctly describes the fix. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[NavigationVelocityFloatingObstacleEnvCfg\n4096 envs] --> B[PhysxCfg GPU Buffers]
B --> C["gpu_max_rigid_contact_count\n2^25 = 33.5M\n(was default 2^23 = 8.4M)"]
B --> D["gpu_max_rigid_patch_count\n2^23 = 8.4M\n(was 2^21 = 2.1M)"]
B --> E["gpu_found_lost_pairs_capacity\n2^23 = 8.4M\n(was default 2^21 = 2.1M)"]
C --> F[Pinned host memory\nContact stream buffer]
D --> G[Pinned host memory\nPatch stream buffer]
E --> H[GPU global memory\nBroadphase pair buffer]
F --> I[Resolves GPU overflow at scale]
G --> I
H --> I
Reviews (1): Last reviewed commit: "Updates PhysX GPU buffer dimensions for ..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review Summary
This PR correctly addresses PhysX GPU buffer overflow errors for the ARL Robot 1 navigation environment by increasing buffer capacities.
Changes Reviewed
navigation_env_cfg.py
The buffer dimension changes look appropriate for a complex navigation environment with obstacles:
| Parameter | Before | After | Factor |
|---|---|---|---|
gpu_max_rigid_contact_count |
(default) | 2²⁵ (~33M) | Added |
gpu_max_rigid_patch_count |
2²¹ (~2M) | 2²³ (~8M) | 4x |
gpu_found_lost_pairs_capacity |
(default) | 2²³ (~8M) | Added |
These values are consistent with other complex environments in the codebase (e.g., shadow_hand_env_cfg.py uses 2²³ for contact/patch counts).
Changelog fragment — Properly follows the changelog fragment convention.
✅ No Issues Found
- Buffer sizing — The chosen values provide adequate headroom for environments with many collision pairs (obstacles + drone contacts).
- Configuration pattern — Follows the established Isaac Lab pattern for PhysxCfg overrides.
- No test coverage needed — This is a config-only fix for runtime buffer errors; no new tests required.
Minor Note
The "Check for Broken Links" CI check is failing, but this appears unrelated to the changes in this PR (the PR does not modify documentation links).
Automated review by isaaclab-review-bot | Review Guidelines
Description
Updates PhysX GPU buffer dimensions for ARL navigation environment to resolve GPU buffer overflow errors from PhysX.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there